From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.90.117.16 with SMTP id p16cs243742agc; Mon, 19 Oct 2009 11:55:30 -0700 (PDT) Received: by 10.224.78.105 with SMTP id j41mr2754774qak.371.1255978529890; Mon, 19 Oct 2009 11:55:29 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 8si5069913qyk.124.2009.10.19.11.55.29; Mon, 19 Oct 2009 11:55:29 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 85DC118582C2; Mon, 19 Oct 2009 14:55:29 -0400 (EDT) Received: from tihlde.org (colargol.tihlde.org [158.38.48.10]) by rubyforge.org (Postfix) with ESMTP id B19581858249 for ; Mon, 19 Oct 2009 14:55:18 -0400 (EDT) Received: by tihlde.org (Postfix, from userid 1623) id D4625101C00C; Mon, 19 Oct 2009 16:07:26 +0200 (CEST) From: Helge Titlestad To: sup-talk Date: Mon, 19 Oct 2009 16:07:26 +0200 Message-Id: <1255961127-sup-3168@tihlde.org> User-Agent: Sup/0.9 Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1255961246-857955-28658-9956-1-=" MIME-Version: 1.0 Subject: [sup-talk] [PATCH] detect and set charset on text/* attachments X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org --=-1255961246-857955-28658-9956-1-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline I got some feedback from non-suppers that my utf-8 text attachments were messed up. When I checked they (the MIME headers) lacked any info on charset, which I believe should be set for text/*. Here's a patch that uses the chardet gem to (try to) detect the appropriate charset and sets it in the Content-Type header. Can't guarantee its robustness - have only tried on a couple of text files and one non-text file. Please tell me if I should use some different way of sending patches... This git flow is a bit new to me. (= -- alge --=-1255961246-857955-28658-9956-1-= Content-Disposition: attachment; filename="0001-Detect-charset-for-text-file-attachments.patch" Content-Type: application/octet-stream; name="0001-Detect-charset-for-text-file-attachments.patch" Content-Transfer-Encoding: base64 RnJvbSA3MzVhNWNlYjc1NzU5OWFmNzE3MDJkNGVjZThkMjljYjExZjJjNjVi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWxnZSBUaXRsZXN0 YWQgPGhlbGdlZHRAdGlobGRlLm9yZz4KRGF0ZTogTW9uLCAxOSBPY3QgMjAw OSAxNjowMzo1NiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIERldGVjdCBjaGFy c2V0IGZvciB0ZXh0LyogZmlsZSBhdHRhY2htZW50cy4KCkFkZHMgZGVwZW5k ZW5jeSBvbiBjaGFyZGV0IGdlbSwgYW5kIHVzZXMgaXQgdG8gZGV0ZWN0IHRo ZSBjaGFyc2V0LgotLS0KIFJFQURNRS50eHQgICAgICB8ICAgIDEgKwogUmFr ZWZpbGUgICAgICAgIHwgICAgMSArCiBsaWIvc3VwL3V0aWwucmIgfCAgICA4 ICsrKysrKystCiAzIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9SRUFETUUudHh0IGIvUkVB RE1FLnR4dAppbmRleCA0MjA0MjcwLi4zYTk4ZmEzIDEwMDY0NAotLS0gYS9S RUFETUUudHh0CisrKyBiL1JFQURNRS50eHQKQEAgLTEwNiw2ICsxMDYsNyBA QCBDdXJyZW50IGxpbWl0YXRpb25zIHdoaWNoIHdpbGwgYmUgZml4ZWQ6CiAg LSBtaW1lLXR5cGVzCiAgLSBnZXR0ZXh0CiAgLSBmYXN0dGhyZWFkCisgLSBj aGFyZGV0CiAKID09IElOU1RBTEw6CiAKZGlmZiAtLWdpdCBhL1Jha2VmaWxl IGIvUmFrZWZpbGUKaW5kZXggNjdjZDBkMi4uM2ZiMGQ1ZSAxMDA2NDQKLS0t IGEvUmFrZWZpbGUKKysrIGIvUmFrZWZpbGUKQEAgLTU3LDYgKzU3LDcgQEAg c3BlYyA9IEdlbTo6U3BlY2lmaWNhdGlvbi5uZXcgZG8gfHN8CiAgIHMuYWRk X2RlcGVuZGVuY3kgIm1pbWUtdHlwZXMiLCAifj4gMSIKICAgcy5hZGRfZGVw ZW5kZW5jeSAiZ2V0dGV4dCIKICAgcy5hZGRfZGVwZW5kZW5jeSAiZmFzdHRo cmVhZCIKKyAgcy5hZGRfZGVwZW5kZW5jeSAiY2hhcmRldCIsICI+PSAwLjku MCIKIGVuZAogCiBSYWtlOjpHZW1QYWNrYWdlVGFzay5uZXcoc3BlYykgZG8g fHBrZ3wKZGlmZiAtLWdpdCBhL2xpYi9zdXAvdXRpbC5yYiBiL2xpYi9zdXAv dXRpbC5yYgppbmRleCBmOTllMWMxLi5lZjdiODkyIDEwMDY0NAotLS0gYS9s aWIvc3VwL3V0aWwucmIKKysrIGIvbGliL3N1cC91dGlsLnJiCkBAIC0zLDYg KzMsNyBAQCByZXF1aXJlICdsb2NrZmlsZScKIHJlcXVpcmUgJ21pbWUvdHlw ZXMnCiByZXF1aXJlICdwYXRobmFtZScKIHJlcXVpcmUgJ3NldCcKK3JlcXVp cmUgJ1VuaXZlcnNhbERldGVjdG9yJwogCiAjIyB0aW1lIGZvciBzb21lIG1v bmtleXBhdGNoaW5nIQogY2xhc3MgTG9ja2ZpbGUKQEAgLTcxLDggKzcyLDEz IEBAIG1vZHVsZSBSTWFpbAogCiAgICAgZGVmIHNlbGYubWFrZV9hdHRhY2ht ZW50IHBheWxvYWQsIG1pbWVfdHlwZSwgZW5jb2RpbmcsIGZpbGVuYW1lCiAg ICAgICBhID0gTWVzc2FnZS5uZXcKKworICAgICAgY3MgPSBVbml2ZXJzYWxE ZXRlY3Rvcjo6Y2hhcmRldChwYXlsb2FkKVsnZW5jb2RpbmcnXSBpZiBtaW1l X3R5cGUgPX4gL150ZXh0XC8vaQorICAgICAgY3QgPSAiI3ttaW1lX3R5cGV9 OyBuYW1lPSN7ZmlsZW5hbWUuaW5zcGVjdH0iCisgICAgICBjdCArPSAiOyBj aGFyc2V0PSN7Y3N9IiBpZiBjcworICAgICAgCiAgICAgICBhLmhlYWRlci5h ZGQgIkNvbnRlbnQtRGlzcG9zaXRpb24iLCAiYXR0YWNobWVudDsgZmlsZW5h bWU9I3tmaWxlbmFtZS5pbnNwZWN0fSIKLSAgICAgIGEuaGVhZGVyLmFkZCAi Q29udGVudC1UeXBlIiwgIiN7bWltZV90eXBlfTsgbmFtZT0je2ZpbGVuYW1l Lmluc3BlY3R9IgorICAgICAgYS5oZWFkZXIuYWRkICJDb250ZW50LVR5cGUi LCBjdAogICAgICAgYS5oZWFkZXIuYWRkICJDb250ZW50LVRyYW5zZmVyLUVu Y29kaW5nIiwgZW5jb2RpbmcgaWYgZW5jb2RpbmcKICAgICAgIGEuYm9keSA9 CiAgICAgICAgIGNhc2UgZW5jb2RpbmcKLS0gCjEuNS42LjUKCg== --=-1255961246-857955-28658-9956-1-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk --=-1255961246-857955-28658-9956-1-=--