* [sup-talk] Feature Request: Collecting Lines in Index Mode @ 2009-09-29 18:14 Christian Dietrich 2009-09-30 18:17 ` William Morgan 0 siblings, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-09-29 18:14 UTC (permalink / raw) Hey there, i am using sup now for just a few weeks and it is just amazing how good it works (the lack of folders iritated me a little bit at first). But now to my Request, i would like to have something like datelines in index mode, like: ,----------------- | -- Today | 12:23 ... | 23:42 ... | -- Yesterday | Yest. 9 .... | Yest. 4.... | -- Last week | ..... .--------------- I think this would cause an bigger overview over the mails, especially in the inbox. I tried to implement the feature by my self, but the mapping beetween `curpos' and `@threads' in modes/thread-index-mode.rb made this a little bit hard, and i didn't know how to solve this problem without breaking sup. Perhaps you can give me a hint, how this problem with the direct mapping can be solved. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. ^ permalink raw reply [flat|nested] 22+ messages in thread
* [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-09-29 18:14 [sup-talk] Feature Request: Collecting Lines in Index Mode Christian Dietrich @ 2009-09-30 18:17 ` William Morgan 2009-10-02 20:48 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: William Morgan @ 2009-09-30 18:17 UTC (permalink / raw) Reformatted excerpts from Christian Dietrich's message of 2009-09-29: > i am using sup now for just a few weeks and it is just amazing how > good it works (the lack of folders iritated me a little bit at > first). Welcome! > But now to my Request, i would like to have something like datelines > in index mode, like: Cool idea. I'd like to see how this looks. > I tried to implement the feature by my self, but the mapping beetween > `curpos' and `@threads' in modes/thread-index-mode.rb made this a > little bit hard, and i didn't know how to solve this problem without > breaking sup. Perhaps you can give me a hint, how this problem with > the direct mapping can be solved. If you look at #regen_text, @text and @lines are the two variables that control the display. @text is an array of the GUI elements for each line of the display. Right now it's just set to one line for each thread. You want to add one additional element at the appropriate position. for each date line. GUI elements are represented as arrays of [color, text] pairs; you can look at #text_for_thread_at for an example. Then, you want to make sure that @lines is set correctly. @lines is a map (hash) from line number to thread (so that when the user presses a key, we know which thread the cursor is resting on). Hope that helps. -- William <wmorgan-sup at masanjin.net> ^ permalink raw reply [flat|nested] 22+ messages in thread
* [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-09-30 18:17 ` William Morgan @ 2009-10-02 20:48 ` Christian Dietrich 2009-10-08 7:05 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-10-02 20:48 UTC (permalink / raw) Excerpts from William Morgan's message of Mi Sep 30 20:17:55 +0200 2009: > Cool idea. I'd like to see how this looks. > > > I tried to implement the feature by my self, but the mapping beetween > > `curpos' and `@threads' in modes/thread-index-mode.rb made this a > > little bit hard, and i didn't know how to solve this problem without > > breaking sup. Perhaps you can give me a hint, how this problem with > > the direct mapping can be solved. > > If you look at #regen_text, @text and @lines are the two variables that > control the display. @text is an array of the GUI elements for each line > of the display. Right now it's just set to one line for each thread. You > want to add one additional element at the appropriate position. for each > date line. GUI elements are represented as arrays of [color, text] > pairs; you can look at #text_for_thread_at for an example. > > Then, you want to make sure that @lines is set correctly. @lines is a > map (hash) from line number to thread (so that when the user presses a > key, we know which thread the cursor is resting on). Thank you, that helped a much. I implemented the feature, it is available at git://github.com/stettberger/sup-mail.git branch time_marks, it is one commit ahead of next. It is enabled with setting the config option ":time_markers_in_index_mode: true" At runtime it can be toggled via '%' (just randomly choosen by me) greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-02 20:48 ` Christian Dietrich @ 2009-10-08 7:05 ` Christian Dietrich 2009-10-08 12:31 ` Christopher Bertels 0 siblings, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-10-08 7:05 UTC (permalink / raw) To: sup-talk [-- Attachment #1: Type: text/plain, Size: 717 bytes --] Excerpts from Christian Dietrich's message of Fr Okt 02 22:48:24 +0200 2009: > Thank you, that helped a much. I implemented the feature, it is > available at git://github.com/stettberger/sup-mail.git > branch time_marks, it is one commit ahead of next. It is enabled > with setting the config option ":time_markers_in_index_mode: true" > At runtime it can be toggled via '%' (just randomly choosen by me) Ok now i did a little bit of reworking the code (don't make it sup crash :-) and added a little bit color). The is now :time_marker_color. I attached a screenshot of the time_marks. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. [-- Attachment #2: sup-time-mark.png --] [-- Type: image/png, Size: 38362 bytes --] [-- Attachment #3: Type: text/plain, Size: 140 bytes --] _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 7:05 ` Christian Dietrich @ 2009-10-08 12:31 ` Christopher Bertels 2009-10-08 12:44 ` Christopher Bertels 0 siblings, 1 reply; 22+ messages in thread From: Christopher Bertels @ 2009-10-08 12:31 UTC (permalink / raw) To: sup-talk [-- Attachment #1.1: Type: text/plain, Size: 420 bytes --] Excerpts from Christian Dietrich's message of Do Okt 08 09:05:47 +0200 2009: > Ok now i did a little bit of reworking the code (don't make it sup > crash :-) and added a little bit color). The is now > :time_marker_color. I attached a screenshot of the time_marks. Looks really cool, I'll give it a try :) -- ================================ Christopher Bertels http://www.adztec-independent.de GPG Key ID: 0x2345b203 [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 835 bytes --] [-- Attachment #2: Type: text/plain, Size: 140 bytes --] _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 12:31 ` Christopher Bertels @ 2009-10-08 12:44 ` Christopher Bertels 2009-10-08 18:28 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: Christopher Bertels @ 2009-10-08 12:44 UTC (permalink / raw) To: sup-talk [-- Attachment #1.1: Type: text/plain, Size: 282 bytes --] Ok, I like it so far. But what would really rock (IMO) would be the possibility to collapse all messages, that are from yesterday or 2 weeks ago etc. What do you think? -- ================================ Christopher Bertels http://www.adztec-independent.de GPG Key ID: 0x2345b203 [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 835 bytes --] [-- Attachment #2: Type: text/plain, Size: 140 bytes --] _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 12:44 ` Christopher Bertels @ 2009-10-08 18:28 ` Christian Dietrich 2009-10-08 19:33 ` Christopher Bertels 2009-10-08 20:04 ` Benoît PIERRE 0 siblings, 2 replies; 22+ messages in thread From: Christian Dietrich @ 2009-10-08 18:28 UTC (permalink / raw) To: sup-talk Excerpts from Christopher Bertels's message of Do Okt 08 14:44:32 +0200 2009: > Ok, I like it so far. But what would really rock (IMO) would be the > possibility to collapse all messages, that are from yesterday or 2 > weeks ago etc. > What do you think? Yeah thats cool, i implemented it, just type <Enter> on a Time Mark (after pulling) greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 18:28 ` Christian Dietrich @ 2009-10-08 19:33 ` Christopher Bertels 2009-10-08 19:44 ` Gaute Hope 2009-10-08 20:04 ` Benoît PIERRE 1 sibling, 1 reply; 22+ messages in thread From: Christopher Bertels @ 2009-10-08 19:33 UTC (permalink / raw) To: sup-talk [-- Attachment #1.1: Type: text/plain, Size: 355 bytes --] Excerpts from Christian Dietrich's message of Do Okt 08 20:28:59 +0200 2009: > Yeah thats cool, i implemented it, just type <Enter> on a Time Mark > (after pulling) Indeed, very nice. Thanks :) I'd like to see this in sup's mainline, btw :) -- ================================ Christopher Bertels http://www.adztec-independent.de GPG Key ID: 0x2345b203 [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 969 bytes --] [-- Attachment #2: Type: text/plain, Size: 140 bytes --] _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 19:33 ` Christopher Bertels @ 2009-10-08 19:44 ` Gaute Hope 2009-10-08 20:12 ` Gaute Hope 0 siblings, 1 reply; 22+ messages in thread From: Gaute Hope @ 2009-10-08 19:44 UTC (permalink / raw) To: sup-talk [-- Attachment #1: Type: text/plain, Size: 362 bytes --] Excerpts from Christopher Bertels's message of to. okt. 08 21:33:44 +0200 2009: > Excerpts from Christian Dietrich's message of Do Okt 08 20:28:59 +0200 2009: > > Yeah thats cool, i implemented it, just type <Enter> on a Time Mark > > (after pulling) > > Indeed, very nice. Thanks :) > I'd like to see this in sup's mainline, btw :) +1 ! Looks great! - gaute [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 19:44 ` Gaute Hope @ 2009-10-08 20:12 ` Gaute Hope 2009-10-08 20:26 ` Benoît PIERRE 2009-10-08 20:50 ` Christian Dietrich 0 siblings, 2 replies; 22+ messages in thread From: Gaute Hope @ 2009-10-08 20:12 UTC (permalink / raw) To: sup-talk [-- Attachment #1: Type: text/plain, Size: 570 bytes --] Excerpts from Gaute Hope's message of to. okt. 08 21:44:30 +0200 2009: > Excerpts from Christopher Bertels's message of to. okt. 08 21:33:44 +0200 2009: > > Excerpts from Christian Dietrich's message of Do Okt 08 20:28:59 +0200 2009: > > > Yeah thats cool, i implemented it, just type <Enter> on a Time Mark > > > (after pulling) Would be nice if the '1' keybinding would select the first message and not the first line. Possibly another binding to collapse the current day when a message is selected (maybe h or E to keep things similar to the message view)? - gaute [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 20:12 ` Gaute Hope @ 2009-10-08 20:26 ` Benoît PIERRE 2009-10-09 7:19 ` Christian Dietrich 2009-10-08 20:50 ` Christian Dietrich 1 sibling, 1 reply; 22+ messages in thread From: Benoît PIERRE @ 2009-10-08 20:26 UTC (permalink / raw) To: sup-talk [-- Attachment #1.1: Type: text/plain, Size: 981 bytes --] Excerpts from Gaute Hope's message of Thu Oct 08 22:12:31 +0200 2009: > Excerpts from Gaute Hope's message of to. okt. 08 21:44:30 +0200 2009: > > Excerpts from Christopher Bertels's message of to. okt. 08 21:33:44 +0200 2009: > > > Excerpts from Christian Dietrich's message of Do Okt 08 20:28:59 +0200 2009: > > > > Yeah thats cool, i implemented it, just type <Enter> on a Time Mark > > > > (after pulling) > > Would be nice if the '1' keybinding would select the first message and > not the first line. Possibly another binding to collapse the current day when > a message is selected (maybe h or E to keep things similar to the > message view)? And 't' should select the next thread, not the next line. 'a' and 'A' too, in fact a time tag should only be selectable manually, using Up/Down or 'j'/'k'. Or never if collapsing/expending is possible with a mapping (my vote goes to 'E'). Cheers, -- A: Because it destroys the flow of conversation. Q: Why is top posting dumb? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 197 bytes --] [-- Attachment #2: Type: text/plain, Size: 140 bytes --] _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 20:26 ` Benoît PIERRE @ 2009-10-09 7:19 ` Christian Dietrich 0 siblings, 0 replies; 22+ messages in thread From: Christian Dietrich @ 2009-10-09 7:19 UTC (permalink / raw) To: sup-talk > And 't' should select the next thread, not the next line. 'a' and 'A' > too, in fact a time tag should only be selectable manually, using > Up/Down or 'j'/'k'. Or never if collapsing/expending is possible with a > mapping (my vote goes to 'E'). Jep thats right, i fixed that. Please pull. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 20:12 ` Gaute Hope 2009-10-08 20:26 ` Benoît PIERRE @ 2009-10-08 20:50 ` Christian Dietrich 2009-10-09 7:31 ` Gaute Hope 1 sibling, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-10-08 20:50 UTC (permalink / raw) To: sup-talk > Would be nice if the '1' keybinding would select the first message and > not the first line. Possibly another binding to collapse the current day when > a message is selected (maybe h or E to keep things similar to the > message view)? Yeah, implemented that, and the other two patches in the branch, like the idea. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 20:50 ` Christian Dietrich @ 2009-10-09 7:31 ` Gaute Hope 2009-10-09 7:44 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: Gaute Hope @ 2009-10-09 7:31 UTC (permalink / raw) To: sup-talk [-- Attachment #1: Type: text/plain, Size: 620 bytes --] Excerpts from Christian Dietrich's message of to. okt. 08 22:50:07 +0200 2009: > > Would be nice if the '1' keybinding would select the first message and > > not the first line. Possibly another binding to collapse the current day when > > a message is selected (maybe h or E to keep things similar to the > > message view)? > > Yeah, implemented that, and the other two patches in the branch, > like the idea. This doesn't work for me: '1'/'^' just makes the view scroll one down; hiding the Today marker (same as hitting 'J' one time). 0 works like expected. a/A/&/d/S/t and E seems to be working alright. - gaute [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-09 7:31 ` Gaute Hope @ 2009-10-09 7:44 ` Christian Dietrich 2009-10-09 9:45 ` Gaute Hope 0 siblings, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-10-09 7:44 UTC (permalink / raw) To: sup-talk Excerpts from Gaute Hope's message of Fr Okt 09 09:31:38 +0200 2009: > This doesn't work for me: '1'/'^' just makes the view scroll one down; hiding > the > Today marker (same as hitting 'J' one time). 0 works like expected. > > a/A/&/d/S/t and E seems to be working alright. Yeah ok, that should be fixed now. (I didn't even now about this keystroke before...) greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-09 7:44 ` Christian Dietrich @ 2009-10-09 9:45 ` Gaute Hope 2009-10-09 10:12 ` Gaute Hope 0 siblings, 1 reply; 22+ messages in thread From: Gaute Hope @ 2009-10-09 9:45 UTC (permalink / raw) To: sup-talk [-- Attachment #1: Type: text/plain, Size: 1026 bytes --] Excerpts from Christian Dietrich's message of fr. okt. 09 09:44:02 +0200 2009: > Excerpts from Gaute Hope's message of Fr Okt 09 09:31:38 +0200 2009: > > This doesn't work for me: '1'/'^' just makes the view scroll one down; hiding > > the > > Today marker (same as hitting 'J' one time). 0 works like expected. > > > > a/A/&/d/S/t and E seems to be working alright. > > Yeah ok, that should be fixed now. (I didn't even now about this > keystroke before...) Just discovered a weird bug.. when this thread got polled and updated the message count, in this case (13), got attached to the thread beneath, which only had one message, and appeared where it shouldn't be anything.. the top thread didn't have any post count. It seemed to only have affected the top two messages, as the count on the third one seemed normal. Not entierly sure what caused it since I can't really reproduce it by sending myself emails.. if it happens again ill post screenshot. Im using time_marker branch rebased ontop of origin/next. - gaute [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-09 9:45 ` Gaute Hope @ 2009-10-09 10:12 ` Gaute Hope 2009-10-09 10:39 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: Gaute Hope @ 2009-10-09 10:12 UTC (permalink / raw) To: sup-talk [-- Attachment #1.1: Type: text/plain, Size: 466 bytes --] Excerpts from Gaute Hope's message of fr. okt. 09 11:45:13 +0200 2009: > Not entierly sure what caused it since I can't really reproduce it by > sending myself emails.. if it happens again ill post screenshot. > > Im using time_marker branch rebased ontop of origin/next. Ok.. now the top message count just got copied down to the line beneath (which should be empty). Sup had just been running for a while, no new messages, didn't happen on first pool.. - gaute [-- Attachment #1.2: 2009-10-09-120801_634x755_scrot.png --] [-- Type: image/png, Size: 29135 bytes --] [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-09 10:12 ` Gaute Hope @ 2009-10-09 10:39 ` Christian Dietrich 2009-10-09 11:00 ` Gaute Hope 0 siblings, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-10-09 10:39 UTC (permalink / raw) To: sup-talk Excerpts from Gaute Hope's message of Fr Okt 09 12:12:21 +0200 2009: > Excerpts from Gaute Hope's message of fr. okt. 09 11:45:13 +0200 2009: > > Not entierly sure what caused it since I can't really reproduce it by > > sending myself emails.. if it happens again ill post screenshot. > > > > Im using time_marker branch rebased ontop of origin/next. > > Ok.. now the top message count just got copied down to the line > beneath (which should be empty). Sup had just been running for a while, > no new messages, didn't happen on first pool.. I have no idea whats causing this, seems like the data of two threads is mixed together? greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-09 10:39 ` Christian Dietrich @ 2009-10-09 11:00 ` Gaute Hope 2009-10-12 7:11 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: Gaute Hope @ 2009-10-09 11:00 UTC (permalink / raw) To: sup-talk [-- Attachment #1: Type: text/plain, Size: 1118 bytes --] Excerpts from Christian Dietrich's message of fr. okt. 09 12:39:27 +0200 2009: > Excerpts from Gaute Hope's message of Fr Okt 09 12:12:21 +0200 2009: > > Excerpts from Gaute Hope's message of fr. okt. 09 11:45:13 +0200 2009: > > > Not entierly sure what caused it since I can't really reproduce it by > > > sending myself emails.. if it happens again ill post screenshot. > > > > > > Im using time_marker branch rebased ontop of origin/next. > > > > Ok.. now the top message count just got copied down to the line > > beneath (which should be empty). Sup had just been running for a while, > > no new messages, didn't happen on first pool.. > > I have no idea whats causing this, seems like the data of two > threads is mixed together? Or the thread count isn't aware of the Today mark and still thinks line 2 is thread 2? Don't really know anything about the implementation. When it happens it doesn't dissapear before I do a M or there is a pull that redraws the screen.. just pressing Ctrl+L or opening/closing a thread doesn't remove it. As said earlier it only seems to affect the top two threads. - gaute [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-09 11:00 ` Gaute Hope @ 2009-10-12 7:11 ` Christian Dietrich 2009-10-12 19:23 ` Christian Dietrich 0 siblings, 1 reply; 22+ messages in thread From: Christian Dietrich @ 2009-10-12 7:11 UTC (permalink / raw) To: sup-talk Excerpts from Gaute Hope's message of Fr Okt 09 13:00:19 +0200 2009: > Or the thread count isn't aware of the Today mark and still thinks line > 2 is thread 2? Don't really know anything about the implementation. > > When it happens it doesn't dissapear before I do a M or there is a pull > that redraws the screen.. just pressing Ctrl+L or opening/closing a > thread doesn't remove it. > > As said earlier it only seems to affect the top two threads. Hi, i also experienced now this Problem, but can't see were this problem is located, because i don't touch the internal states of the threads. There must be one @thread[curpos] left, which causes this Problem. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-12 7:11 ` Christian Dietrich @ 2009-10-12 19:23 ` Christian Dietrich 0 siblings, 0 replies; 22+ messages in thread From: Christian Dietrich @ 2009-10-12 19:23 UTC (permalink / raw) To: sup-talk Excerpts from Christian Dietrich's message of Mo Okt 12 09:11:35 +0200 2009: > Excerpts from Gaute Hope's message of Fr Okt 09 13:00:19 +0200 2009: > > Or the thread count isn't aware of the Today mark and still thinks line > > 2 is thread 2? Don't really know anything about the implementation. > > > > When it happens it doesn't dissapear before I do a M or there is a pull > > that redraws the screen.. just pressing Ctrl+L or opening/closing a > > thread doesn't remove it. > > > > As said earlier it only seems to affect the top two threads. > > Hi, > i also experienced now this Problem, but can't see were this problem > is located, because i don't touch the internal states of the > threads. There must be one @thread[curpos] left, which causes this > Problem. > > greetz didi Hi, i think i've fixed the problem now, it was a wrong mapping in update_text_for_line, now the situation that caused the error before succeeds. There was a misguiding declaration of @size_widgets in the init function. @size_widgets isn't a Hash, mapping line numbers to a size_widget, it is the same index as in @threads for the specific thread. greetz didi PS: please pull :-) -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [sup-talk] Feature Request: Collecting Lines in Index Mode 2009-10-08 18:28 ` Christian Dietrich 2009-10-08 19:33 ` Christopher Bertels @ 2009-10-08 20:04 ` Benoît PIERRE 1 sibling, 0 replies; 22+ messages in thread From: Benoît PIERRE @ 2009-10-08 20:04 UTC (permalink / raw) To: sup-talk [-- Attachment #1.1.1: Type: text/plain, Size: 711 bytes --] Excerpts from Christian Dietrich's message of Thu Oct 08 20:28:59 +0200 2009: > Excerpts from Christopher Bertels's message of Do Okt 08 14:44:32 +0200 2009: > > Ok, I like it so far. But what would really rock (IMO) would be the > > possibility to collapse all messages, that are from yesterday or 2 > > weeks ago etc. > > What do you think? > > Yeah thats cool, i implemented it, just type <Enter> on a Time Mark > (after pulling) This is great, I love it. Attached 2 small patches: - fix a warning (space before opening parenthesis in function call) - fix a bug with thread selection when time marks are not visible Cheers, -- A: Because it destroys the flow of conversation. Q: Why is top posting dumb? [-- Attachment #1.1.2: 0001-warning-fix.patch --] [-- Type: application/octet-stream, Size: 770 bytes --] From 996bb1d6d9f2d41051f27353dda314a3733d6093 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Beno=C3=AEt=20PIERRE?= <benoit.pierre@gmail.com> Date: Thu, 8 Oct 2009 21:38:07 +0200 Subject: [PATCH 1/2] warning fix --- lib/sup/modes/thread-index-mode.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb index c302ae2..4593af2 100644 --- a/lib/sup/modes/thread-index-mode.rb +++ b/lib/sup/modes/thread-index-mode.rb @@ -769,7 +769,7 @@ protected else thread = @lines[l] if thread - @text[l] = text_for_thread_at (@threads.index(thread)) + @text[l] = text_for_thread_at(@threads.index(thread)) buffer.mark_dirty if buffer end end -- 1.6.3.3 [-- Attachment #1.1.3: 0002-fix-selection-when-time-marks-are-disabled.patch --] [-- Type: application/octet-stream, Size: 1114 bytes --] From fa3d6ac72b2fd037872fd01e27bdec6588653aa6 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Beno=C3=AEt=20PIERRE?= <benoit.pierre@gmail.com> Date: Thu, 8 Oct 2009 21:40:29 +0200 Subject: [PATCH 2/2] fix selection when time marks are disabled Don't try to toggle an invisible time mark, which prevent selection of some threads (like the first one whose position match the 'Today' mark). --- lib/sup/modes/thread-index-mode.rb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb index 4593af2..a9d1eeb 100644 --- a/lib/sup/modes/thread-index-mode.rb +++ b/lib/sup/modes/thread-index-mode.rb @@ -103,12 +103,14 @@ EOS ## open up a thread view window def select t=nil, when_done=nil + if $config[:time_markers_in_index_mode] marker = @time_marks.select {|m| m[3] == curpos }[0] if marker marker[2] = ! marker[2] # Toggle visibility of this marker regen_text return end + end t ||= cursor_thread or return Redwood::reporting_thread("load messages for thread-view-mode") do -- 1.6.3.3 [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 243 bytes --] [-- Attachment #2: Type: text/plain, Size: 140 bytes --] _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2009-10-12 19:23 UTC | newest] Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2009-09-29 18:14 [sup-talk] Feature Request: Collecting Lines in Index Mode Christian Dietrich 2009-09-30 18:17 ` William Morgan 2009-10-02 20:48 ` Christian Dietrich 2009-10-08 7:05 ` Christian Dietrich 2009-10-08 12:31 ` Christopher Bertels 2009-10-08 12:44 ` Christopher Bertels 2009-10-08 18:28 ` Christian Dietrich 2009-10-08 19:33 ` Christopher Bertels 2009-10-08 19:44 ` Gaute Hope 2009-10-08 20:12 ` Gaute Hope 2009-10-08 20:26 ` Benoît PIERRE 2009-10-09 7:19 ` Christian Dietrich 2009-10-08 20:50 ` Christian Dietrich 2009-10-09 7:31 ` Gaute Hope 2009-10-09 7:44 ` Christian Dietrich 2009-10-09 9:45 ` Gaute Hope 2009-10-09 10:12 ` Gaute Hope 2009-10-09 10:39 ` Christian Dietrich 2009-10-09 11:00 ` Gaute Hope 2009-10-12 7:11 ` Christian Dietrich 2009-10-12 19:23 ` Christian Dietrich 2009-10-08 20:04 ` Benoît PIERRE
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
![[-- Attachment #2: sup-time-mark.png --] [-- Type: image/png, Size: 38362 bytes --]](../../1254985425-sup-2303@peer.zerties.org/2-sup-time-mark.png){kind=link}
![[-- Attachment #1.2: 2009-10-09-120801_634x755_scrot.png --] [-- Type: image/png, Size: 29135 bytes --]](../../1255083021-sup-226@qwerzila/1.2-2009-10-09-120801_634x755_scrot.png){kind=link}