Re: [sup-talk] Feature Request: Collecting Lines in Index Mode

From: "Benoît PIERRE" <benoit.pierre@gmail.com>
To: sup-talk <sup-talk@rubyforge.org>
Subject: Re: [sup-talk] Feature Request: Collecting Lines in Index Mode
Date: Thu, 08 Oct 2009 22:04:10 +0200	[thread overview]
Message-ID: <1255032019-sup-3406@localdomain> (raw)
In-Reply-To: <1255026503-sup-3624@peer.zerties.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 711 bytes --]

Excerpts from Christian Dietrich's message of Thu Oct 08 20:28:59 +0200 2009:
> Excerpts from Christopher Bertels's message of Do Okt 08 14:44:32 +0200 2009:
> > Ok, I like it so far. But what would really rock (IMO) would be the
> > possibility to collapse all messages, that are from yesterday or 2
> > weeks ago etc.
> > What do you think?
> 
> Yeah thats cool, i implemented it, just type <Enter> on a Time Mark
> (after pulling)

This is great, I love it. Attached 2 small patches:
- fix a warning (space before opening parenthesis in function call)
- fix a bug with thread selection when time marks are not visible

Cheers,
-- 
A: Because it destroys the flow of conversation.
Q: Why is top posting dumb?

[-- Attachment #1.1.2: 0001-warning-fix.patch --]
[-- Type: application/octet-stream, Size: 770 bytes --]

From 996bb1d6d9f2d41051f27353dda314a3733d6093 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Beno=C3=AEt=20PIERRE?= <benoit.pierre@gmail.com>
Date: Thu, 8 Oct 2009 21:38:07 +0200
Subject: [PATCH 1/2] warning fix

---
 lib/sup/modes/thread-index-mode.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index c302ae2..4593af2 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -769,7 +769,7 @@ protected
     else
 	  thread = @lines[l]
 	  if thread
-	      @text[l] = text_for_thread_at (@threads.index(thread))
+	      @text[l] = text_for_thread_at(@threads.index(thread))
 		  buffer.mark_dirty if buffer
 	  end
     end
-- 
1.6.3.3


[-- Attachment #1.1.3: 0002-fix-selection-when-time-marks-are-disabled.patch --]
[-- Type: application/octet-stream, Size: 1114 bytes --]

From fa3d6ac72b2fd037872fd01e27bdec6588653aa6 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Beno=C3=AEt=20PIERRE?= <benoit.pierre@gmail.com>
Date: Thu, 8 Oct 2009 21:40:29 +0200
Subject: [PATCH 2/2] fix selection when time marks are disabled

Don't try to toggle an invisible time mark, which prevent selection of
some threads (like the first one whose position match the 'Today' mark).
---
 lib/sup/modes/thread-index-mode.rb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 4593af2..a9d1eeb 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -103,12 +103,14 @@ EOS
 
   ## open up a thread view window
   def select t=nil, when_done=nil
+    if $config[:time_markers_in_index_mode]
 	marker = @time_marks.select {|m| m[3] == curpos }[0]
 	if marker 
 		marker[2] = ! marker[2] # Toggle visibility of this marker
 		regen_text
 		return
 	end
+    end
     t ||= cursor_thread or return
 
     Redwood::reporting_thread("load messages for thread-view-mode") do
-- 
1.6.3.3


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 243 bytes --]

[-- Attachment #2: Type: text/plain, Size: 140 bytes --]

_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk
