From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.90.92.18 with SMTP id p18cs210842agb; Tue, 6 Oct 2009 23:44:46 -0700 (PDT) Received: by 10.224.55.148 with SMTP id u20mr2194035qag.191.1254897885362; Tue, 06 Oct 2009 23:44:45 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 42si11332791qyk.64.2009.10.06.23.44.45; Tue, 06 Oct 2009 23:44:45 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-talk-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-talk-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id E26DE18582C7; Wed, 7 Oct 2009 02:44:44 -0400 (EDT) Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88]) by rubyforge.org (Postfix) with ESMTP id 7F19818582BA for ; Wed, 7 Oct 2009 02:44:35 -0400 (EDT) Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69) (envelope-from ) id 1MvQGI-0003eD-RB; Wed, 07 Oct 2009 02:44:34 -0400 From: Rich Lane To: Ben Gamari In-reply-to: <1254845543-sup-9458@ben-laptop> References: <1254844050-sup-4148@ben-laptop> <1254844166-sup-1028@ben-laptop> <1254845543-sup-9458@ben-laptop> Date: Wed, 07 Oct 2009 02:44:34 -0400 Message-Id: <1254896214-sup-5969@zyrg.net> User-Agent: Sup/git Cc: sup-talk Subject: Re: [sup-talk] Crash while in thread-view-mode X-BeenThere: sup-talk@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: User & developer discussion of Sup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-talk-bounces@rubyforge.org Errors-To: sup-talk-bounces@rubyforge.org Excerpts from Ben Gamari's message of Tue Oct 06 12:15:46 -0400 2009: > Excerpts from Ben Gamari's message of Tue Oct 06 11:53:18 -0400 2009: > > Well, it seems like whatever caused the crash earlier did something to > > my index. Now any attempt to open a thread-index-mode of my LKML label > > (which I was viewing in the earlier crash) causes the client to > > immediately crash. > > > > Hmm, it seems like the problem is spreading. I now come to find out that > another label triggers this same crash (although I guess it's possible > that the intersection of the two labels is non-nil). I tried running a > sup-sync -oc on the relevant sources to no avail. I really don't have > time to devote to debugging this at the moment so it looks like I might > need to take another hiatus from sup. Just as I was starting to get used > to it... sigh. Anyways, if anyone has any ideas for improving things, > let me know. Thanks! I've been seeing this crash for a long time. I think it's a race between the poll thread / load-more-threads thread and the rest of the UI in the main thread. Basically any operation on a thread object in ThreadIndexMode needs to be protected against ThreadSet#add_message (and probably other ThreadSet methods) because add_message can remove containers from the thread tree, leaving you with an empty thread whose "date" method returns nil. You could try running sup with the -n flag to disable threading. The major downside is that you have to hit P to poll manually. I look forward to having a sup-server - I plan on writing a little android client in Scala using actors. Almost no mutable state and absolutely no ncurses. _______________________________________________ sup-talk mailing list sup-talk@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-talk