* [sup-talk] Bug: Opening PGP encrypted mails fails with latest revision
@ 2009-09-20 19:51 Michael Stapelberg
2009-09-25 19:08 ` Michael Stapelberg
0 siblings, 1 reply; 3+ messages in thread
From: Michael Stapelberg @ 2009-09-20 19:51 UTC (permalink / raw)
Hi,
when opening PGP encrypted mails (MIME), sup crashes with the following
exception:
--- NoMethodError from thread: load messages for thread-view-mode
undefined method `expandable?' for nil:NilClass
/usr/lib/ruby/1.8/sup/modes/thread-view-mode.rb:621:in `regen_text'
/usr/lib/ruby/1.8/sup/modes/thread-view-mode.rb:616:in `each'
/usr/lib/ruby/1.8/sup/modes/thread-view-mode.rb:616:in `regen_text'
/usr/lib/ruby/1.8/sup/thread.rb:68:in `each'
/usr/lib/ruby/1.8/sup/thread.rb:168:in `each_with_stuff'
/usr/lib/ruby/1.8/sup/thread.rb:67:in `each'
/usr/lib/ruby/1.8/sup/modes/thread-view-mode.rb:585:in `regen_text'
/usr/lib/ruby/1.8/sup/modes/thread-view-mode.rb:135:in `initialize'
/usr/lib/ruby/1.8/sup/modes/thread-index-mode.rb:112:in `new'
/usr/lib/ruby/1.8/sup/modes/thread-index-mode.rb:112:in `select'
/usr/lib/ruby/1.8/sup.rb:77:in `reporting_thread'
/usr/lib/ruby/1.8/sup.rb:75:in `initialize'
/usr/lib/ruby/1.8/sup.rb:75:in `new'
/usr/lib/ruby/1.8/sup.rb:75:in `reporting_thread'
/usr/lib/ruby/1.8/sup/modes/thread-index-mode.rb:102:in `select'
/usr/lib/ruby/1.8/sup/mode.rb:50:in `send'
/usr/lib/ruby/1.8/sup/mode.rb:50:in `handle_input'
/usr/lib/ruby/1.8/sup/buffer.rb:265:in `handle_input'
bin/sup:236
Best regards,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* [sup-talk] Bug: Opening PGP encrypted mails fails with latest revision
2009-09-20 19:51 [sup-talk] Bug: Opening PGP encrypted mails fails with latest revision Michael Stapelberg
@ 2009-09-25 19:08 ` Michael Stapelberg
2009-09-26 18:10 ` William Morgan
0 siblings, 1 reply; 3+ messages in thread
From: Michael Stapelberg @ 2009-09-25 19:08 UTC (permalink / raw)
Hi,
Excerpts from Michael Stapelberg's message of So Sep 20 21:51:38 +0200 2009:
> when opening PGP encrypted mails (MIME), sup crashes with the following
> exception:
Further debugging revealed that this has been introduced in revision
927b7df4b2052a6b3c2ae1f2b44a6bc901315f8d and can be fixed with the following
patch:
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -413,7 +413,7 @@ private
notice, sig, decryptedm = CryptoManager.decrypt payload
if decryptedm # managed to decrypt
children = message_to_chunks(decryptedm, true)
- [notice, sig, children]
+ [notice, sig, children].flatten.compact
else
[notice]
end
Best regards,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread* [sup-talk] Bug: Opening PGP encrypted mails fails with latest revision
2009-09-25 19:08 ` Michael Stapelberg
@ 2009-09-26 18:10 ` William Morgan
0 siblings, 0 replies; 3+ messages in thread
From: William Morgan @ 2009-09-26 18:10 UTC (permalink / raw)
Reformatted excerpts from Michael Stapelberg's message of 2009-09-25:
> Further debugging revealed that this has been introduced in revision
> 927b7df4b2052a6b3c2ae1f2b44a6bc901315f8d and can be fixed with the
> following patch:
Thanks, this should be fixed in git. Give it a try.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-26 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-20 19:51 [sup-talk] Bug: Opening PGP encrypted mails fails with latest revision Michael Stapelberg
2009-09-25 19:08 ` Michael Stapelberg
2009-09-26 18:10 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox