Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: cworth@cworth.org (Carl Worth)
Subject: [sup-talk] Ignore killed messages in U screen
Date: Fri, 04 Sep 2009 08:12:01 -0700	[thread overview]
Message-ID: <1252076900-sup-274@yoom.home.cworth.org> (raw)
In-Reply-To: <1252074924-sup-1994@masanjin.net>

Excerpts from William Morgan's message of Fri Sep 04 07:41:49 -0700 2009:
> Yes. That's why killed is special; it requires work at threading time to
> drop threads in which any message has a killed label, regardless of
> whether that's the message that matched the query.

Good. I'm glad I'm at least understanding how things work here.

> The other way to implement this, FWIW, is to have labels automatically
> spread to all messages in a thread when they're applied. I think that is
> probably a better implementation, though it increases the cost at
> labeling time. I've been toying with this idea in the sup server code.
> 
> > If not, it seems like it would be possible for a query like
> > "!label:killed" to do exactly what is wanted without needing any
> > special treatment for killed internally.
> 
> I think the above implementation would allow this.

Yes, that would do the trick. It would require extra work both at the
time a label is attached to a message and then again at the time a new
message is associated with an existing thread. But it would give me
the behavior I want "for free" after that.

If such an implementation would be acceptable, then it would seem that
a better long-term solution would be to apply labels only to "thread
objects" and to index and search for those rather than individuals
messages (at least as far as label searching goes). Of course, I'm
talking from an entirely naive point-of-view with regard to the
implementation impact of such a change, but I would imagine it
wouldn't be trivial.

-Carl


  reply	other threads:[~2009-09-04 15:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27 15:36 Edward Z. Yang
2009-08-27 15:50 ` Ben Walton
2009-08-27 15:56 ` Edward Z. Yang
2009-09-03 19:25   ` Rich Lane
2009-09-03 23:06     ` Carl Worth
2009-09-04 14:41       ` William Morgan
2009-09-04 15:12         ` Carl Worth [this message]
2009-09-03 18:47 ` William Morgan
2009-09-03 18:57   ` Edward Z. Yang
2009-09-03 18:58     ` William Morgan
2009-09-03 19:01       ` Edward Z. Yang
2009-09-30 19:56         ` William Morgan
2009-10-01  7:36           ` Nicolas Pouillard
2009-10-01 13:34             ` William Morgan
2009-10-01 14:07               ` Nicolas Pouillard
2009-10-01 17:13                 ` Carl Worth
2009-10-06 17:11                   ` William Morgan
2009-09-03 19:13   ` Ben Walton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252076900-sup-274@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox