From: rlane@club.cc.cmu.edu (Rich Lane)
Subject: [sup-talk] Ignore killed messages in U screen
Date: Thu, 03 Sep 2009 15:25:03 -0400 [thread overview]
Message-ID: <1252005520-sup-9555@zyrg.net> (raw)
In-Reply-To: <1251388546-sup-7744@javelin>
Excerpts from Edward Z. Yang's message of Thu Aug 27 11:56:32 -0400 2009:
> Excerpts from Edward Z. Yang's message of Thu Aug 27 11:36:28 -0400 2009:
> > - SearchResultsMode.spawn_from_query "is:unread"
> > + SearchResultsMode.spawn_from_query "is:unread !label:killed"
>
> I might have one legitimate objection to this patch, which is
> that searches should ignore killed tags unless explicitly told
> not to.
By default Index#load_messages_in_thread_for does skip killed threads,
so you should already have the behavior you want without modifying the
query (unless you're using an old xapian-index version that doesn't
support killed threads). Adding a !label:killed term will actually cause
threads that are "killed" (have at least one message labeled killed) but
also have a message not labeled killed that matches the query to be
displayed, which I don't think is the behavior you're looking for.
next prev parent reply other threads:[~2009-09-03 19:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 15:36 Edward Z. Yang
2009-08-27 15:50 ` Ben Walton
2009-08-27 15:56 ` Edward Z. Yang
2009-09-03 19:25 ` Rich Lane [this message]
2009-09-03 23:06 ` Carl Worth
2009-09-04 14:41 ` William Morgan
2009-09-04 15:12 ` Carl Worth
2009-09-03 18:47 ` William Morgan
2009-09-03 18:57 ` Edward Z. Yang
2009-09-03 18:58 ` William Morgan
2009-09-03 19:01 ` Edward Z. Yang
2009-09-30 19:56 ` William Morgan
2009-10-01 7:36 ` Nicolas Pouillard
2009-10-01 13:34 ` William Morgan
2009-10-01 14:07 ` Nicolas Pouillard
2009-10-01 17:13 ` Carl Worth
2009-10-06 17:11 ` William Morgan
2009-09-03 19:13 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252005520-sup-9555@zyrg.net \
--to=rlane@club.cc.cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox