Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] Add 'a' and 'd' keybindings to thread-view-mode to archive/delete current thread
Date: Thu, 03 Sep 2009 11:06:55 -0700	[thread overview]
Message-ID: <1252000831-sup-9922@masanjin.net> (raw)
In-Reply-To: <1251325542-sup-3105@yoom.home.cworth.org>

Reformatted excerpts from Carl Worth's message of 2009-08-26:
> These behave identically to the existing ",a" and ",d" commands, (that
> is they archive or delete the current thread and then view the next).

Sorry it's taken me so long to look at this. Thanks for the patch!

I'm curious what other people think about this. On the one hand, it's
only additional keybindings, so it's not going to adversely affect
anyone. On the other hand, there is a nice balance with the ".", ","
and "]" commands which this disrupts, and it can't be extended to the
other commands from thread-index-mode. And on the third hand, I'm happy
to have keybinding hooks.

I guess if most people primarily closes their thread-view-modes using
",a" and ",d", then I'm fine with this.
-- 
William <wmorgan-sup at masanjin.net>


  reply	other threads:[~2009-09-03 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 22:40 Carl Worth
2009-09-03 18:06 ` William Morgan [this message]
2009-09-03 18:37   ` Mark Alexander
2009-09-03 18:58     ` Nicholas Bergson-Shilcock
2009-09-06 19:43   ` Nicolas Pouillard
2009-09-08 20:26     ` Carl Worth
2009-09-08 20:33       ` Nicolas Pouillard
2009-09-08 15:17   ` Wirt Wolff
2009-09-08 20:08     ` William Morgan
2009-09-09 14:37       ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252000831-sup-9922@masanjin.net \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox