From mboxrd@z Thu Jan  1 00:00:00 1970
From: bburky@bburky.com (Blake Burkhart)
Date: Sun, 30 Aug 2009 16:50:09 -0500
Subject: [sup-talk] [PATCH] remove use of Object#tap
In-Reply-To: <1251664798-sup-8169@Backspace.local>
References: <1251664135-1383-1-git-send-email-rlane@club.cc.cmu.edu>
	<1251664798-sup-8169@Backspace.local>
Message-ID: <1251668806-sup-7253@Backspace.local>

Excerpts from Blake Burkhart's message of Sun Aug 30 15:45:48 -0500 2009:
> After applying this on next in hopes it lets me run sup on ruby 1.8.6, it
> doesn't work.
> 
> It crashed with this log:
> $ SUP_INDEX=xapian ruby -Ilib bin/sup-sync --all --all-sources --restore
> ~/dumpfile
> Loading state dump from /Users/blake/dumpfile...
> Read 6790 entries from dump file.
> Scanning maildir:/Users/blake/Mail/bburky/INBOX...
> [Sun Aug 30 15:38:57 -0500 2009] hook: read 'before-add-message' from
> /Users/blake/.sup/hooks/before-add-message.rb
> [Sun Aug 30 15:38:57 -0500 2009] hook[before-add-message]: Marking message
> 1234774373-sup-1128 at zo as suptalk, subject is 'Re: [sup-talk] (no subject)'
> ./lib/sup/label.rb:64:in `<<': expecting a symbol (ArgumentError)
>     from ./lib/sup/util.rb:520:in `send'
>     from ./lib/sup/util.rb:520:in `method_missing'
>     from ./lib/sup/xapian_index.rb:114:in `sync_message'
>     from
> /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/set.rb:1
> 89:in `each'
>     from
> /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/set.rb:1
> 89:in `each_key'
>     from
> /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/set.rb:1
> 89:in `each'
>     from ./lib/sup/xapian_index.rb:114:in `sync_message'
>     from ./lib/sup/xapian_index.rb:87:in `add_message'
>      ... 10 levels...
>     from ./lib/sup/util.rb:520:in `method_missing'
>     from bin/sup-sync:146
>     from bin/sup-sync:141:in `each'
>     from bin/sup-sync:141
> 
> However, I'm having other odd problems too with labels anyway. On the ferret
> version of sup, I'm not able to apply labels with the 'l' command. However, I
> have a hook for applying a label from the List-ID that does still work. So
> this patch may or may not work, I think I'm possibly having problems of my
> own.
I got it to work. Mostly a least. What does a sup-dump file actually store? I
lost all read/unread statuses and all labels (including the spam label thing,
I assume it's just a normal label).

To get it to work, I removed my before-add-message hook. It has worked for a
long time, through different versions of sup, etc. However, It doesn't seem to
be working with xapian.

I don't actually know where this code came from, possibly this list, or maybe
else where. I may have even modified it, I don't really remember. The hook is
this:

listIdMatch = message.raw_header.match(/List-Id:.*?<(.*?)>\s*$/i)

if(listIdMatch)
  listIdLabel = listIdMatch[1].split(/\./).first.sub(/[^0-9A-Za-z]/, "")
  message.add_label listIdLabel
  log "Marking message #{message.id} as #{listIdLabel}, subject is '#{message.subj}'"
end

> Actually, I haven't tried to restore from a dumpfile for ferret. I'll do that
> later and see if it works.

I did try a restore from dumpfile with ferret. It worked except it didn't
remember the labels the same way xapian didn't. However, the hook did work,
and created labels on all mailing list messages.

I think this isn't a xapian problem, because ferret is acting the same.

If I want to recreate the sup files from scratch, what do I need to have? My
config.yaml, sources.yaml, sent.mbox and a dumpfile? Is that all?