From mboxrd@z Thu Jan 1 00:00:00 1970 From: cworth@cworth.org (Carl Worth) Date: Wed, 26 Aug 2009 14:35:25 -0700 Subject: [sup-talk] [PATCH] Make SUP_LOG_LEVEL self-documenting. In-Reply-To: <1250972634-sup-6871@masanjin.net> References: <1250745799-sup-6607@yoom.home.cworth.org> <1250972634-sup-6871@masanjin.net> Message-ID: <1251322427-sup-9184@yoom.home.cworth.org> The idea here is that if someone is looking at the log and not seeing the information of interest, then the log itself should tell them how to get more information, (by suggesting to set SUP_LOG_LEVEL to the next lower level). --- Excerpts from William Morgan's message of Sat Aug 22 13:25:22 -0700 2009: > It all looks good except you can use Logger::LEVELS to access the > constants. Then there's no need to write a LEVELS method. If you fix > that I will apply. Thanks! Thanks. I had the distinct feeling I was doing something wrong there. Here's a corrected version. -Carl bin/sup | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/bin/sup b/bin/sup index 3d5b6c1..cdf1ff2 100755 --- a/bin/sup +++ b/bin/sup @@ -169,6 +169,9 @@ begin lmode.on_kill { Logger.clear! } Logger.add_sink lmode Logger.force_message "Welcome to Sup! Log level is set to #{Logger.level}." + if Logger::LEVELS.index(Logger.level) > 0 + Logger.force_message "For more verbose logging, restart with SUP_LOG_LEVEL=#{Logger::LEVELS[Logger::LEVELS.index(Logger.level)-1]}." + end debug "initializing inbox buffer" imode = InboxMode.new -- 1.6.3.3 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available URL: