From mboxrd@z Thu Jan 1 00:00:00 1970 From: cworth@cworth.org (Carl Worth) Date: Wed, 26 Aug 2009 14:15:36 -0700 Subject: [sup-talk] [PATCH 2/2] ui responsiveness tweaks In-Reply-To: <1251053171-11450-2-git-send-email-rlane@club.cc.cmu.edu> References: <1251053171-11450-1-git-send-email-rlane@club.cc.cmu.edu> <1251053171-11450-2-git-send-email-rlane@club.cc.cmu.edu> Message-ID: <1251318620-sup-3031@yoom.home.cworth.org> My message here really has nothing to do with Rich's patches specifically, (so sorry about that), but his patches happened to provide the perfect context for an issue I wanted to bring up. As is typical of git-formatted patches, Rich's emails have subject lines from his commit messages: [sup-talk] [PATCH 1/2] preemptively load messages when scrolling [sup-talk] [PATCH 2/2] ui responsiveness tweaks As far as the git commits go, this subject line is one of the most essential pieces of metadata to accompany the patch. Yet by default sup doesn't display it at all, (requiring keypresses to display the header and find the subject line). I think what I would like is for sup to display the subject line everytime it changes significantly in a thread, (specifically not regarding things like an initial "Re: " getting added as significant). I think I'd be willing to spend an entire line's worth of screen real estate for this information---it's quite useful when people do meaningful subject changes for sub-threads. -Carl Excerpts from Rich Lane's message of Sun Aug 23 11:46:11 -0700 2009: > --- > bin/sup | 1 + > lib/sup/modes/thread-index-mode.rb | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/bin/sup b/bin/sup > index 3d5b6c1..f3c6771 100755 > --- a/bin/sup > +++ b/bin/sup > @@ -58,6 +58,7 @@ if $opts[:list_hooks] > end > > Thread.abort_on_exception = true # make debugging possible > +Thread.current.priority = 1 # keep ui responsive > > module Redwood > > diff --git a/lib/sup/modes/thread-index-mode.rb > b/lib/sup/modes/thread-index-mode.rb > index fb6b2ce..177431b 100644 > --- a/lib/sup/modes/thread-index-mode.rb > +++ b/lib/sup/modes/thread-index-mode.rb > @@ -76,8 +76,7 @@ EOS > @last_load_more_size = nil > to_load_more do |size| > next if @last_load_more_size == 0 > - load_threads :num => 1, :background => false > - load_threads :num => (size - 1), > + load_threads :num => size, > :when_done => lambda { |num| @last_load_more_size = num } > end > end > @@ -627,6 +626,7 @@ EOS > BufferManager.draw_screen > last_update = Time.now > end > + ::Thread.pass > break if @interrupt_search > end > @ts.threads.each { |th| th.labels.each { |l| LabelManager << l } } -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: not available URL: