From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Sat, 22 Aug 2009 13:25:22 -0700 Subject: [sup-talk] [PATCH] Make SUP_LOG_LEVEL self-documenting. In-Reply-To: <1250745799-sup-6607@yoom.home.cworth.org> References: <1250745799-sup-6607@yoom.home.cworth.org> Message-ID: <1250972634-sup-6871@masanjin.net> Reformatted excerpts from Carl Worth's message of 2009-08-19: > I'm probably still off as far as standard ruby idioms, (and I'm > probably committing some sup layer violations as well). It all looks good except you can use Logger::LEVELS to access the constants. Then there's no need to write a LEVELS method. If you fix that I will apply. Thanks! -- William