* [sup-talk] [PATCH] fix garbaged text in textfield when using ncursesw
@ 2009-08-19 20:56 Benoît PIERRE
2009-08-22 15:01 ` William Morgan
0 siblings, 1 reply; 2+ messages in thread
From: Benoît PIERRE @ 2009-08-19 20:56 UTC (permalink / raw)
Apparently, field_buffer content is not initialized to blanks when using
the wide-character version of ncurses. Forcing a call to
set_field_buffer fix the problem.
---
lib/sup/textfield.rb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sup/textfield.rb b/lib/sup/textfield.rb
index b8dec59..76803bf 100644
--- a/lib/sup/textfield.rb
+++ b/lib/sup/textfield.rb
@@ -35,9 +35,9 @@ class TextField
@completion_block = block
@field = Ncurses::Form.new_field 1, @width - question.length, @y, @x + question.length, 256, 0
@form = Ncurses::Form.new_form [@field]
- @value = default
+ @value = default || ''
Ncurses::Form.post_form @form
- set_cursed_value default if default
+ set_cursed_value @value
end
def position_cursor
--
1.6.3.3
--
A: Because it destroys the flow of conversation.
Q: Why is top posting dumb?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090819/95de5c6f/attachment.bin>
^ permalink raw reply [flat|nested] 2+ messages in thread* [sup-talk] [PATCH] fix garbaged text in textfield when using ncursesw
2009-08-19 20:56 [sup-talk] [PATCH] fix garbaged text in textfield when using ncursesw Benoît PIERRE
@ 2009-08-22 15:01 ` William Morgan
0 siblings, 0 replies; 2+ messages in thread
From: William Morgan @ 2009-08-22 15:01 UTC (permalink / raw)
Reformatted excerpts from Beno?t PIERRE's message of 2009-08-19:
> Apparently, field_buffer content is not initialized to blanks when
> using the wide-character version of ncurses. Forcing a call to
> set_field_buffer fix the problem.
Awesome. Applied to master. I hope this clears up the problems that
people have been having with newer ncurses ruby libraries and utf8. If
you've been seeing garbage characters when searching, please let us know
if this fixes it.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-22 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-19 20:56 [sup-talk] [PATCH] fix garbaged text in textfield when using ncursesw Benoît PIERRE
2009-08-22 15:01 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox