From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] sup crashing after sending mail
Date: Wed, 05 Aug 2009 08:29:27 -0700 [thread overview]
Message-ID: <1249486021-sup-1246@masanjin.net> (raw)
In-Reply-To: <CBBB81512D1FE445823400465FCCFFF2D8AA45@sluga.fer.hr>
Hi Igor,
Reformatted excerpts from Igor Brkic's message of 2009-08-02:
> For mail sending I use sSMTP and my ISP's SMTP server. When I try to
> send mail from sup, after pressing y on keyboard, mail gets sent but
> sup crashes (exception-log_0.txt in attachment).
A few people have reported this and I'm trying to track it down. Would
you mind applying the following patch, and then running:
sup-sync -a sup://sent
Hopefully that will generate a little debugging output I can use. Thanks!
diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 5372fc7..fc9af59 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -92,11 +92,11 @@ class Message
begin
Time.parse date
rescue ArgumentError => e
- #Redwood::log "faking mangled date header for #{@id} (orig #{header['date']
+ Redwood::log "faking mangled date header for #{@id} (orig #{header['date'].
Time.now
end
else
- #Redwood::log "faking non-existent date header for #{@id}"
+ Redwood::log "faking non-existent date header for #{@id}"
Time.now
end
diff --git a/lib/sup/poll.rb b/lib/sup/poll.rb
index 354bd21..365f828 100644
--- a/lib/sup/poll.rb
+++ b/lib/sup/poll.rb
@@ -148,7 +148,9 @@ EOS
labels = labels + (source.archived? ? [] : [:inbox])
m = Message.new :source => source, :source_info => offset, :labels => label
+ Redwood::log "XX before load: #{m.date.inspect}"
m.load_from_source!
+ Redwood::log "XX after load: #{m.date.inspect}"
if m.source_marked_read?
m.remove_label :unread
@@ -157,7 +159,9 @@ EOS
docid, entry = Index.load_entry_for_id m.id
HookManager.run "before-add-message", :message => m
+ Redwood::log "XX after add-message: #{m.date.inspect}"
m = yield(m, offset, entry) or next if block_given?
+ Redwood::log "XX after yield: #{m.date.inspect}"
times = Index.sync_message m, false, docid, entry, opts
UpdateManager.relay self, :added, m unless entry
end
--
William <wmorgan-sup at masanjin.net>
next parent reply other threads:[~2009-08-05 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CBBB81512D1FE445823400465FCCFFF2D8AA45@sluga.fer.hr>
2009-08-05 15:29 ` William Morgan [this message]
2009-08-05 23:24 ` Igor Brkic
2009-08-06 14:40 ` William Morgan
2009-08-06 16:57 ` Igor Brkic
[not found] ` <1249579173-sup-573@xps>
2009-08-06 17:45 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249486021-sup-1246@masanjin.net \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox