From mboxrd@z Thu Jan 1 00:00:00 1970 From: rlane@club.cc.cmu.edu (Rich Lane) Date: Tue, 28 Jul 2009 11:39:16 -0400 Subject: [sup-talk] [PATCH] explicitly load messages in testcase In-Reply-To: <1248793905-sup-2227@masanjin.net> References: <1248757349-11301-1-git-send-email-rlane@club.cc.cmu.edu> <1248793905-sup-2227@masanjin.net> Message-ID: <1248794785-sup-1840@pion.club.cc.cmu.edu> Excerpts from William Morgan's message of Tue Jul 28 11:12:51 -0400 2009: > Hi Rich, > > Not to be a pain, but can you give a little more context for this patch > (and the other two you sent recently)? I'm just trying to understand > what this fixes. Sure. The commit "don't automatically parse header on Message#new" broke test_message because the message id/etc fields are nil until load_from_source! is called. This patch just calls load_from_source! whenever we create a message in the testcase. The other two are fixes for problems reported by Guillaume Quintard. Ferret sup-dump was failing because the query passed to each_id didn't have any positive terms. The date-ceiling code was broken on 32 bit machines because the maximum signed long is 2**31-1, not 2**31.