Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: rlane@club.cc.cmu.edu (Rich Lane)
Subject: [sup-talk] [PATCH] explicitly load messages in testcase
Date: Tue, 28 Jul 2009 11:39:16 -0400	[thread overview]
Message-ID: <1248794785-sup-1840@pion.club.cc.cmu.edu> (raw)
In-Reply-To: <1248793905-sup-2227@masanjin.net>

Excerpts from William Morgan's message of Tue Jul 28 11:12:51 -0400 2009:
> Hi Rich,
> 
> Not to be a pain, but can you give a little more context for this patch
> (and the other two you sent recently)? I'm just trying to understand
> what this fixes.

Sure. The commit "don't automatically parse header on Message#new" broke
test_message because the message id/etc fields are nil until
load_from_source! is called. This patch just calls load_from_source!
whenever we create a message in the testcase.

The other two are fixes for problems reported by Guillaume Quintard.
Ferret sup-dump was failing because the query passed to each_id didn't
have any positive terms. The date-ceiling code was broken on 32 bit
machines because the maximum signed long is 2**31-1, not 2**31.


  reply	other threads:[~2009-07-28 15:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28  5:02 Rich Lane
2009-07-28 15:12 ` William Morgan
2009-07-28 15:39   ` Rich Lane [this message]
2009-07-28 16:04     ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248794785-sup-1840@pion.club.cc.cmu.edu \
    --to=rlane@club.cc.cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox