* [sup-talk] [PATCH] Put labels before subject in thread index view.
@ 2009-05-23 18:25 Mark Alexander
2009-05-23 19:22 ` Ben Walton
[not found] ` <1243125562-sup-287@cabinet>
0 siblings, 2 replies; 5+ messages in thread
From: Mark Alexander @ 2009-05-23 18:25 UTC (permalink / raw)
This patch is probably controversial, and I expect it
to be rejected. But I really like the way Gmail puts
the labels before the subject, and I've duplicated that here.
It helps out at work, where subject lines tend to be very
long, pushing the labels past the right edge of the window.
---
lib/sup/modes/thread-index-mode.rb | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index f65d241..897dca7 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -843,10 +843,11 @@ protected
[subj_color, size_widget_text],
[:to_me_color, t.labels.member?(:attachment) ? "@" : " "],
[:to_me_color, dp ? ">" : (p ? '+' : " ")],
- [subj_color, t.subj + (t.subj.empty? ? "" : " ")],
] +
- (t.labels - @hidden_labels).map { |label| [:label_color, "+#{label} "] } +
- [[:snippet_color, snippet]
+ (t.labels - @hidden_labels).map { |label| [:label_color, "#{label} "] } +
+ [
+ [subj_color, t.subj + (t.subj.empty? ? "" : " ")],
+ [:snippet_color, snippet],
]
end
--
1.5.6.3
^ permalink raw reply [flat|nested] 5+ messages in thread* [sup-talk] [PATCH] Put labels before subject in thread index view.
2009-05-23 18:25 [sup-talk] [PATCH] Put labels before subject in thread index view Mark Alexander
@ 2009-05-23 19:22 ` Ben Walton
2009-05-23 21:42 ` Nicolas Pouillard
[not found] ` <1243125562-sup-287@cabinet>
1 sibling, 1 reply; 5+ messages in thread
From: Ben Walton @ 2009-05-23 19:22 UTC (permalink / raw)
Excerpts from Mark Alexander's message of Sat May 23 14:25:57 -0400 2009:
>
> This patch is probably controversial, and I expect it
> to be rejected. But I really like the way Gmail puts
> the labels before the subject, and I've duplicated that here.
> It helps out at work, where subject lines tend to be very
> long, pushing the labels past the right edge of the window.
I'll give the idea a +1. I'd prefer labels first also. It would also
be more uniform when you get mail without a subject...[why yes, I do
get those from people! :(].
I didn't look at the patch itself, so this comment is purely on the
idea.
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu
Contact me to arrange for a CAcert assurance meeting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090523/df5d8b16/attachment.bin>
^ permalink raw reply [flat|nested] 5+ messages in thread* [sup-talk] [PATCH] Put labels before subject in thread index view.
2009-05-23 19:22 ` Ben Walton
@ 2009-05-23 21:42 ` Nicolas Pouillard
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Pouillard @ 2009-05-23 21:42 UTC (permalink / raw)
Excerpts from Ben Walton's message of Sat May 23 21:22:28 +0200 2009:
> Excerpts from Mark Alexander's message of Sat May 23 14:25:57 -0400 2009:
> >
> > This patch is probably controversial, and I expect it
> > to be rejected. But I really like the way Gmail puts
> > the labels before the subject, and I've duplicated that here.
> > It helps out at work, where subject lines tend to be very
> > long, pushing the labels past the right edge of the window.
>
> I'll give the idea a +1. I'd prefer labels first also. It would also
> be more uniform when you get mail without a subject...[why yes, I do
> get those from people! :(].
>
> I didn't look at the patch itself, so this comment is purely on the
> idea.
+1 to the idea too!
--
Nicolas Pouillard
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1243125562-sup-287@cabinet>]
* [sup-talk] [PATCH] Put labels before subject in thread index view.
[not found] ` <1243125562-sup-287@cabinet>
@ 2009-05-24 12:48 ` Henri Ducrocq
2009-05-27 16:07 ` William Morgan
1 sibling, 0 replies; 5+ messages in thread
From: Henri Ducrocq @ 2009-05-24 12:48 UTC (permalink / raw)
Excerpts from Marc Hartstein's message of Sun May 24 01:42:20 +0100 2009:
> This is a great idea, but can we get it configurable/delegated to a
> hook? Bonus points if there's a straightforward way to be able to
> switch between the two modes at runtime.
>
> I've occasionally thought I'd want this, as I get a lot of long subject
> too, but I wouldn't want multiply-tagged messages [especially with
> special tags like inbox and unread] to have the tags obscure the
> subject.
We could have an even more configurable presentation of the messages,
with the possibility of having a multiline view, e.g. subject on the
first line, labels on the second, excerpt of the text on the 3rd...
--
Henri
^ permalink raw reply [flat|nested] 5+ messages in thread* [sup-talk] [PATCH] Put labels before subject in thread index view.
[not found] ` <1243125562-sup-287@cabinet>
2009-05-24 12:48 ` Henri Ducrocq
@ 2009-05-27 16:07 ` William Morgan
1 sibling, 0 replies; 5+ messages in thread
From: William Morgan @ 2009-05-27 16:07 UTC (permalink / raw)
Reformatted excerpts from Marc Hartstein's message of 2009-05-23:
> This is a great idea, but can we get it configurable/delegated to a
> hook?
I'd be happy to add an index-model-subject-widget hook, similar to the
index-mode-size-widget hook, if someone wants to write one.
> I've occasionally thought I'd want this, as I get a lot of long
> subject too, but I wouldn't want multiply-tagged messages [especially
> with special tags like inbox and unread] to have the tags obscure the
> subject.
Unread, starred, and other system labels shouldn't be displayed in
thread-view-mode. Index will, except in inbox-mode. It might not be too
bad.
I'll apply this patch and we'll see who yells.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-05-27 16:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-23 18:25 [sup-talk] [PATCH] Put labels before subject in thread index view Mark Alexander
2009-05-23 19:22 ` Ben Walton
2009-05-23 21:42 ` Nicolas Pouillard
[not found] ` <1243125562-sup-287@cabinet>
2009-05-24 12:48 ` Henri Ducrocq
2009-05-27 16:07 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox