* [sup-talk] Inconsistent inbox after restart
@ 2009-04-28 19:19 Steve Goldman
2009-04-29 8:17 ` Tyberius Prime
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Steve Goldman @ 2009-04-28 19:19 UTC (permalink / raw)
This only started happening after I upgraded to the latest version...
Oftentimes when I quit sup and then restart, my inbox looks different.
Messages that I had previously archived are back in the inbox. Has
anyone else seen this? I'm losing sleep over it.
Thanks.
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-28 19:19 [sup-talk] Inconsistent inbox after restart Steve Goldman
@ 2009-04-29 8:17 ` Tyberius Prime
2009-04-29 8:40 ` Nicolas Pouillard
2009-04-29 18:10 ` William Morgan
2 siblings, 0 replies; 14+ messages in thread
From: Tyberius Prime @ 2009-04-29 8:17 UTC (permalink / raw)
Hi,
yes, I see the same,
haven't dug into it so far either, simply never restart sup
if I can avoid it... (yeah, great conflict strategy, but
life's short).
So long,
Tyberius Prime
Excerpts from Steve Goldman's message of Tue Apr 28 21:19:26 +0200 2009:
> This only started happening after I upgraded to the latest version...
>
> Oftentimes when I quit sup and then restart, my inbox looks different.
> Messages that I had previously archived are back in the inbox. Has
> anyone else seen this? I'm losing sleep over it.
>
> Thanks.
> --
>
> Steve Goldman
> sgoldman at tower-research.com
>
> T: 212.219.6014
> F: 212.219.6007
>
> Tower Research Capital, LLC
> 377 Broadway, 11th Fl.
> New York, NY 10013
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-29 8:40 ` Nicolas Pouillard
@ 2009-04-29 8:37 ` Tyberius Prime
0 siblings, 0 replies; 14+ messages in thread
From: Tyberius Prime @ 2009-04-29 8:37 UTC (permalink / raw)
I should add, the read status is being kept for me.
Excerpts from Nicolas Pouillard's message of Wed Apr 29 10:40:13 +0200 2009:
> Excerpts from Steve Goldman's message of Tue Apr 28 21:19:26 +0200 2009:
> > This only started happening after I upgraded to the latest version...
> >
> > Oftentimes when I quit sup and then restart, my inbox looks different.
> > Messages that I had previously archived are back in the inbox. Has
> > anyone else seen this? I'm losing sleep over it.
>
> From time to time I also encounter this issue: previously archived emails
> come back to the inbox.
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-28 19:19 [sup-talk] Inconsistent inbox after restart Steve Goldman
2009-04-29 8:17 ` Tyberius Prime
@ 2009-04-29 8:40 ` Nicolas Pouillard
2009-04-29 8:37 ` Tyberius Prime
2009-04-29 18:10 ` William Morgan
2 siblings, 1 reply; 14+ messages in thread
From: Nicolas Pouillard @ 2009-04-29 8:40 UTC (permalink / raw)
Excerpts from Steve Goldman's message of Tue Apr 28 21:19:26 +0200 2009:
> This only started happening after I upgraded to the latest version...
>
> Oftentimes when I quit sup and then restart, my inbox looks different.
> Messages that I had previously archived are back in the inbox. Has
> anyone else seen this? I'm losing sleep over it.
From time to time I also encounter this issue: previously archived emails
come back to the inbox.
--
Nicolas Pouillard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-28 19:19 [sup-talk] Inconsistent inbox after restart Steve Goldman
2009-04-29 8:17 ` Tyberius Prime
2009-04-29 8:40 ` Nicolas Pouillard
@ 2009-04-29 18:10 ` William Morgan
2009-04-30 7:11 ` Tyberius Prime
2 siblings, 1 reply; 14+ messages in thread
From: William Morgan @ 2009-04-29 18:10 UTC (permalink / raw)
Reformatted excerpts from Steve Goldman's message of 2009-04-28:
> Oftentimes when I quit sup and then restart, my inbox looks different.
> Messages that I had previously archived are back in the inbox. Has
> anyone else seen this? I'm losing sleep over it.
I see it periodically too (I think I also see read messages turned
unread again) and have been trying to find a pattern---is it email
that's autosaved when I quit Sup, etc.?
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-29 18:10 ` William Morgan
@ 2009-04-30 7:11 ` Tyberius Prime
2009-04-30 12:51 ` Steve Goldman
0 siblings, 1 reply; 14+ messages in thread
From: Tyberius Prime @ 2009-04-30 7:11 UTC (permalink / raw)
For me it seems to be messages that have been saved 'hours' ago by pressing $.
Excerpts from William Morgan's message of Wed Apr 29 20:10:53 +0200 2009:
> Reformatted excerpts from Steve Goldman's message of 2009-04-28:
> > Oftentimes when I quit sup and then restart, my inbox looks different.
> > Messages that I had previously archived are back in the inbox. Has
> > anyone else seen this? I'm losing sleep over it.
>
> I see it periodically too (I think I also see read messages turned
> unread again) and have been trying to find a pattern---is it email
> that's autosaved when I quit Sup, etc.?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-30 7:11 ` Tyberius Prime
@ 2009-04-30 12:51 ` Steve Goldman
2009-04-30 13:10 ` Ben Walton
2009-04-30 13:19 ` William Morgan
0 siblings, 2 replies; 14+ messages in thread
From: Steve Goldman @ 2009-04-30 12:51 UTC (permalink / raw)
Excerpts from Tyberius Prime's message of Thu Apr 30 03:11:29 -0400 2009:
> For me it seems to be messages that have been saved 'hours' ago by pressing $.
>
> Excerpts from William Morgan's message of Wed Apr 29 20:10:53 +0200 2009:
> > Reformatted excerpts from Steve Goldman's message of 2009-04-28:
> > > Oftentimes when I quit sup and then restart, my inbox looks different.
> > > Messages that I had previously archived are back in the inbox. Has
> > > anyone else seen this? I'm losing sleep over it.
> >
> > I see it periodically too (I think I also see read messages turned
> > unread again) and have been trying to find a pattern---is it email
> > that's autosaved when I quit Sup, etc.?
I have confirmed that 0.7 is fine, but master is not. So we just have
to track down which commit(s) in between broke it...
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-30 12:51 ` Steve Goldman
@ 2009-04-30 13:10 ` Ben Walton
2009-04-30 13:36 ` William Morgan
2009-04-30 13:19 ` William Morgan
1 sibling, 1 reply; 14+ messages in thread
From: Ben Walton @ 2009-04-30 13:10 UTC (permalink / raw)
On Thu, Apr 30, 2009 at 8:51 AM, Steve Goldman
<sgoldman at tower-research.com> wrote:
> Excerpts from Tyberius Prime's message of Thu Apr 30 03:11:29 -0400 2009:
>> For me it seems to be messages that have been saved 'hours' ago by pressing $.
>
> I have confirmed that 0.7 is fine, but master is not. ?So we just have
> to track down which commit(s) in between broke it...
git-bisect to the rescue? Anyone experiencing this and comfortable
with git that wants to track down where the problem was introduced?
It may take a little while, unless the problem can be recreated at
will, but the bisect tool is awesome for situations like this.
-Ben
--
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <bdwalton at gmail.com>
"With or without religion, good people can behave well and bad people
can do evil; but for good people to do evil?that takes religion. "
-Steven Weinberg
---------------------------------------------------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-30 12:51 ` Steve Goldman
2009-04-30 13:10 ` Ben Walton
@ 2009-04-30 13:19 ` William Morgan
1 sibling, 0 replies; 14+ messages in thread
From: William Morgan @ 2009-04-30 13:19 UTC (permalink / raw)
Reformatted excerpts from Steve Goldman's message of 2009-04-30:
> I have confirmed that 0.7 is fine, but master is not. So we just have
> to track down which commit(s) in between broke it...
Ok, now we're onto something! As an educated guess, I've published a
branch revert-background-save, which is identical to master except that
the commits on the background-save branch have been reverted. Can you
try that branch please?
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-30 13:10 ` Ben Walton
@ 2009-04-30 13:36 ` William Morgan
2009-04-30 14:23 ` Steve Goldman
0 siblings, 1 reply; 14+ messages in thread
From: William Morgan @ 2009-04-30 13:36 UTC (permalink / raw)
Reformatted excerpts from Ben Walton's message of 2009-04-30:
> git-bisect to the rescue? Anyone experiencing this and comfortable
> with git that wants to track down where the problem was introduced?
> It may take a little while, unless the problem can be recreated at
> will, but the bisect tool is awesome for situations like this.
If the educated guesses fall through, then we'll punish Steve for his
insulin by making him binary search through all commits since 0.7.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-04-30 13:36 ` William Morgan
@ 2009-04-30 14:23 ` Steve Goldman
[not found] ` <f96e0240904300729l1493160eqdcc642af5aae1c15@mail.gmail.com>
0 siblings, 1 reply; 14+ messages in thread
From: Steve Goldman @ 2009-04-30 14:23 UTC (permalink / raw)
Excerpts from William Morgan's message of Thu Apr 30 09:36:22 -0400 2009:
> Reformatted excerpts from Ben Walton's message of 2009-04-30:
> > git-bisect to the rescue? Anyone experiencing this and comfortable
> > with git that wants to track down where the problem was introduced?
> > It may take a little while, unless the problem can be recreated at
> > will, but the bisect tool is awesome for situations like this.
>
> If the educated guesses fall through, then we'll punish Steve for his
> insulin by making him binary search through all commits since 0.7.
Bad news. This new branch is also buggy.
Time to apply the force of brute.
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
[not found] ` <f96e0240904300729l1493160eqdcc642af5aae1c15@mail.gmail.com>
@ 2009-05-01 20:23 ` Steve Goldman
2009-05-04 13:32 ` William Morgan
0 siblings, 1 reply; 14+ messages in thread
From: Steve Goldman @ 2009-05-01 20:23 UTC (permalink / raw)
I have found the offensive commit...
Whoever was working on this, can you take a look and figure out where
the bug is?
(And for all you perl bashers out there, given this ridiculous line
of ruby, you officially can't talk any more shit.)
063ec996a24b13b5dc9a59e21aa42ba629ab510a
--- a/lib/sup/poll.rb
+++ b/lib/sup/poll.rb
@@ -97,7 +97,7 @@ EOS
numi = 0
add_messages_from source do |m, offset, entry|
## always preserve the labels on disk.
- m.labels = entry[:label].split(/\s+/).map { |x| x.intern } if entry
+ m.labels = ((m.labels - [:unread, :inbox]) + entry[:label].split(/\s+/).map { |x| x.intern }).uniq if entry
yield "Found message at #{offset} with labels {#{m.labels * ', '}}"
unless entry
num += 1
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-05-01 20:23 ` Steve Goldman
@ 2009-05-04 13:32 ` William Morgan
2009-05-04 13:46 ` Steve Goldman
0 siblings, 1 reply; 14+ messages in thread
From: William Morgan @ 2009-05-04 13:32 UTC (permalink / raw)
Reformatted excerpts from Steve Goldman's message of 2009-05-01:
> I have found the offensive commit...
Interesting. I think I see the problem. Were all the messages that
magically reappeared in your inbox messages that were sent to mailing
lists, or otherwise messages that somehow appeared twice in your inbox?
> (And for all you perl bashers out there, given this ridiculous line
> of ruby, you officially can't talk any more shit.)
No one here has bashed Perl. Personally I prefer bashing Python (when
I'm not too busy bashing Java (when I'm not too busy bashing C++)), and
credit Perl for much of what I like about Ruby.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [sup-talk] Inconsistent inbox after restart
2009-05-04 13:32 ` William Morgan
@ 2009-05-04 13:46 ` Steve Goldman
0 siblings, 0 replies; 14+ messages in thread
From: Steve Goldman @ 2009-05-04 13:46 UTC (permalink / raw)
Excerpts from William Morgan's message of Mon May 04 09:32:04 -0400 2009:
> Reformatted excerpts from Steve Goldman's message of 2009-05-01:
> > I have found the offensive commit...
>
> Interesting. I think I see the problem. Were all the messages that
> magically reappeared in your inbox messages that were sent to mailing
> lists, or otherwise messages that somehow appeared twice in your inbox?
Most of the messages I archive come from lists, so this is possible.
The lists I'm on are smart enough to not deliver messages twice, most
of the time.
> > (And for all you perl bashers out there, given this ridiculous line
> > of ruby, you officially can't talk any more shit.)
>
> No one here has bashed Perl. Personally I prefer bashing Python (when
> I'm not too busy bashing Java (when I'm not too busy bashing C++)), and
> credit Perl for much of what I like about Ruby.
Live and let live!!
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2009-05-04 13:46 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-28 19:19 [sup-talk] Inconsistent inbox after restart Steve Goldman
2009-04-29 8:17 ` Tyberius Prime
2009-04-29 8:40 ` Nicolas Pouillard
2009-04-29 8:37 ` Tyberius Prime
2009-04-29 18:10 ` William Morgan
2009-04-30 7:11 ` Tyberius Prime
2009-04-30 12:51 ` Steve Goldman
2009-04-30 13:10 ` Ben Walton
2009-04-30 13:36 ` William Morgan
2009-04-30 14:23 ` Steve Goldman
[not found] ` <f96e0240904300729l1493160eqdcc642af5aae1c15@mail.gmail.com>
2009-05-01 20:23 ` Steve Goldman
2009-05-04 13:32 ` William Morgan
2009-05-04 13:46 ` Steve Goldman
2009-04-30 13:19 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox