* [sup-talk] Patch for using default colors
@ 2009-03-21 12:57 Mark Alexander
2009-03-23 15:12 ` William Morgan
0 siblings, 1 reply; 5+ messages in thread
From: Mark Alexander @ 2009-03-21 12:57 UTC (permalink / raw)
I noticed that sup wasn't using my terminal's
default colors when displaying the text of
a message. Instead of the expected black on
light-yellow (my defaults), it was using white on black.
I also see a message in the mailing list archives
from Jan 29 titled "When using 'default' in colors.yaml
or colormap.rb, sup throws an exception" that seems
to describe the same problem.
I have attached a patch that works for me, and might
be a workaround for the other problem as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: defaultcolors.patch
Type: text/x-patch
Size: 281 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090321/3756fefe/attachment.bin>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] Patch for using default colors
2009-03-21 12:57 [sup-talk] Patch for using default colors Mark Alexander
@ 2009-03-23 15:12 ` William Morgan
2009-03-23 15:25 ` William Morgan
2009-03-23 16:34 ` Mark Alexander
0 siblings, 2 replies; 5+ messages in thread
From: William Morgan @ 2009-03-23 15:12 UTC (permalink / raw)
Reformatted excerpts from Mark Alexander's message of 2009-03-21:
> I noticed that sup wasn't using my terminal's default colors when
> displaying the text of a message. Instead of the expected black on
> light-yellow (my defaults), it was using white on black.
Thanks for the patch. I've started a topic branch called default-colors.
Currently using this patch makes Sup look crazy for me, so I haven't
merged it into next.
I think the problem is the Sup is setting the background color to be
black. Parts of the screen have the "ncurses default" and parts of it
have black. I do think it's a step in the right direction though.
> I also see a message in the mailing list archives from Jan 29 titled
> "When using 'default' in colors.yaml or colormap.rb, sup throws an
> exception" that seems to describe the same problem.
This is a different problem, having to do with Sup's notion of a default
color. From what I recall it was a YAML issue or something.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] Patch for using default colors
2009-03-23 15:12 ` William Morgan
@ 2009-03-23 15:25 ` William Morgan
2009-03-23 16:34 ` Mark Alexander
1 sibling, 0 replies; 5+ messages in thread
From: William Morgan @ 2009-03-23 15:25 UTC (permalink / raw)
Reformatted excerpts from William Morgan's message of 2009-03-23:
> This is a different problem, having to do with Sup's notion of a
> default color. From what I recall it was a YAML issue or something.
Nope, I was misremembering. You were right on the money---that was a
related bug. In fact, it contained the other half of the solution.
I've merged default-colors into next. Give it a shot.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] Patch for using default colors
2009-03-23 15:12 ` William Morgan
2009-03-23 15:25 ` William Morgan
@ 2009-03-23 16:34 ` Mark Alexander
2009-03-25 16:02 ` William Morgan
1 sibling, 1 reply; 5+ messages in thread
From: Mark Alexander @ 2009-03-23 16:34 UTC (permalink / raw)
Excerpts from William Morgan's message of Mon Mar 23 08:12:55 -0700 2009:
> Reformatted excerpts from Mark Alexander's message of 2009-03-21:
> > I noticed that sup wasn't using my terminal's default colors when
> > displaying the text of a message. Instead of the expected black on
> > light-yellow (my defaults), it was using white on black.
>
> Thanks for the patch. I've started a topic branch called default-colors.
> Currently using this patch makes Sup look crazy for me, so I haven't
> merged it into next.
I half-expected it would look bad for you. I may be seeing the same
thing, but without defining it as "crazy" :-) . For example, when
viewing a short message, I see the text of the message in the proper
default colors. But the blank space below it is all black. I can
live with that, but it's clearly not ideal.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] Patch for using default colors
2009-03-23 16:34 ` Mark Alexander
@ 2009-03-25 16:02 ` William Morgan
0 siblings, 0 replies; 5+ messages in thread
From: William Morgan @ 2009-03-25 16:02 UTC (permalink / raw)
Reformatted excerpts from Mark Alexander's message of 2009-03-23:
> I half-expected it would look bad for you. I may be seeing the same
> thing, but without defining it as "crazy" :-) . For example, when
> viewing a short message, I see the text of the message in the proper
> default colors. But the blank space below it is all black. I can
> live with that, but it's clearly not ideal.
This should be fixed in next. LMK if not.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-25 16:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-21 12:57 [sup-talk] Patch for using default colors Mark Alexander
2009-03-23 15:12 ` William Morgan
2009-03-23 15:25 ` William Morgan
2009-03-23 16:34 ` Mark Alexander
2009-03-25 16:02 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox