From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] Patch for message-id problem
Date: Sun, 22 Mar 2009 09:59:59 -0700 [thread overview]
Message-ID: <1237740682-sup-5677@entry> (raw)
In-Reply-To: <a412e2a70903201011p5ff990ccn6e74fad3cee60648@mail.gmail.com>
Reformatted excerpts from Mark Alexander's message of 2009-03-20:
> Here's a patch for the message-id problem I mentioned earlier, where
> the header line was split into two lines:
Thanks! I've modified this slightly so that the regex looks like:
HEADER_RE = /\s*(.*?)\s*/
which I believe is equivalent to your change.
I've applied the patch directly to master and that will probably be the
last thing going in before an 0.7 release.
> I've added a somewhat large test case to the unit test that is an
> exact copy of a message that was causing me problems, but with the
> company name changed to protect the innocent.
Very useful. Thanks!
A minor comment: for future patches, it will be easier for me to apply
your changes if you use git format-patch instead of git diff.
--
William <wmorgan-sup at masanjin.net>
prev parent reply other threads:[~2009-03-22 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 17:11 Mark Alexander
2009-03-22 16:59 ` William Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237740682-sup-5677@entry \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox