Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Subject: [sup-talk] [PATCH] Fix a recurring bug about killed threads.
Date: Mon, 16 Mar 2009 19:39:40 +0100	[thread overview]
Message-ID: <1237228775-sup-8139@ausone.local> (raw)

Resent...

---
 ...e-60d86dd32054533a6206f698033ec668af6a7574.yaml |   10 ++++++++--
 lib/sup/modes/thread-index-mode.rb                 |    2 +-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/bugs/issue-60d86dd32054533a6206f698033ec668af6a7574.yaml b/bugs/issue-60d86dd32054533a6206f698033ec668af6a7574.yaml
index 7fb616c..2830fff 100644
--- a/bugs/issue-60d86dd32054533a6206f698033ec668af6a7574.yaml
+++ b/bugs/issue-60d86dd32054533a6206f698033ec668af6a7574.yaml
@@ -5,8 +5,8 @@ type: :bugfix
 component: indexing
 release: 
 reporter: William Morgan <wmorgan-sup at masanjin.net>
-status: :unstarted
-disposition: 
+status: :closed
+disposition: :fixed
 creation_time: 2008-04-25 19:28:51.369257 Z
 references: []
 
@@ -20,4 +20,10 @@ log_events:
   - William Morgan <wmorgan-sup at masanjin.net>
   - unassigned from release 0.6
   - ""
+- - 2008-11-21 14:23:17.566852 Z
+  - Nicolas Pouillard <nicolas.pouillard at gmail.com>
+  - closed with disposition fixed
+  - |-
+    Loading options was not given to load_thread_for_message in
+    ThreadIndexMode.add_or_unhide.
 git_branch: 
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 3dd0498..73144db 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -567,7 +567,7 @@ protected
   def add_or_unhide m
     @ts_mutex.synchronize do
       if (is_relevant?(m) || @ts.is_relevant?(m)) && !@ts.contains?(m)
-        @ts.load_thread_for_message m
+        @ts.load_thread_for_message m, @load_thread_opts
       end
 
       @hidden_threads.delete @ts.thread_for(m)

-- 
Nicolas Pouillard


                 reply	other threads:[~2009-03-16 18:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237228775-sup-8139@ausone.local \
    --to=nicolas.pouillard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox