From: sgoldman@tower-research.com (Steve Goldman)
Subject: [sup-talk] [PATCH] use offscreen lines for textfield overflow
Date: Sun, 23 Nov 2008 15:59:49 -0500 [thread overview]
Message-ID: <1227473953-sup-5646@sgoldmanlinux.tower-research.com> (raw)
In the To:, Cc:, Bcc:, etc., prompts, the TextField was initializing
an NCurses form with zero offscreen lines. So when the user typed too
many addresses at the prompt the cursor wrapped around and everything
they had typed was clobbered. This patch initializes the form object
to have 256 offscreen lines (I had no rationale for 256 except that it
is a nice, big power of two). Now the user can type plenty of names
and the wrap-around works as the user would expect.
---
lib/sup/textfield.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/sup/textfield.rb b/lib/sup/textfield.rb
index 479c609..c748c7a 100644
--- a/lib/sup/textfield.rb
+++ b/lib/sup/textfield.rb
@@ -33,7 +33,7 @@ class TextField
@w, @y, @x, @width = window, y, x, width
@question = question
@completion_block = block
- @field = Ncurses::Form.new_field 1, @width - question.length, @y, @x + question.length, 0, 0
+ @field = Ncurses::Form.new_field 1, @width - question.length, @y, @x + question.length, 256, 0
@form = Ncurses::Form.new_form [@field]
@value = default
Ncurses::Form.post_form @form
--
1.5.6.4
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
next reply other threads:[~2008-11-23 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 20:59 Steve Goldman [this message]
2008-11-27 0:33 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227473953-sup-5646@sgoldmanlinux.tower-research.com \
--to=sgoldman@tower-research.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox