Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased.
Date: Sun, 09 Nov 2008 20:55:56 -0800	[thread overview]
Message-ID: <1226292778-sup-1719@entry> (raw)
In-Reply-To: <1226088207-sup-2545@sgoldmanlinux.tower-research.com>

Reformatted excerpts from Steve Goldman's message of 2008-11-07:
> We shouldn't downcase names before we look them up in the alias to
> person hash since the keys of that hash are case sensitive.  This
> brings up a more philosophical question of whether keys in that hash
> SHOULD be case sensitive.  What does it mean to have two aliases
> "Steve" and "steve"?

Certainly, either everything should be case sensitive, or everything
should be case insensitive. The problem here was that creating aliases
was case sensitive, but looking them up wasn't.

Personally I'm fine with case-sensitive aliases. Applied, thanks!
-- 
William <wmorgan-sup at masanjin.net>


      reply	other threads:[~2008-11-10  4:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 20:04 Steve Goldman
2008-11-10  4:55 ` William Morgan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226292778-sup-1719@entry \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox