Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed

* [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased.
@ 2008-11-07 20:04 Steve Goldman
  2008-11-10  4:55 ` William Morgan
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Goldman @ 2008-11-07 20:04 UTC (permalink / raw)


---
We shouldn't downcase names before we look them up in the alias to
person hash since the keys of that hash are case sensitive.  This
brings up a more philosophical question of whether keys in that hash
SHOULD be case sensitive.  What does it mean to have two aliases
"Steve" and "steve"?

 lib/sup/buffer.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index ebc3587..0447f61 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -506,7 +506,7 @@ EOS
     answer = BufferManager.ask_many_emails_with_completions domain, question, completions, default

     if answer
-      answer.split_on_commas.map { |x| ContactManager.contact_for(x.downcase) || PersonManager.person_for(x) }
+      answer.split_on_commas.map { |x| ContactManager.contact_for(x) || PersonManager.person_for(x) }
     end
   end

--
1.5.5
-- 

Steve Goldman
sgoldman at tower-research.com

T: 212.219.6014
F: 212.219.6007

Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013


^ permalink raw reply	[flat|nested] 2+ messages in thread

• * [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased.
    2008-11-07 20:04 [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased Steve Goldman
  @ 2008-11-10  4:55 ` William Morgan
    0 siblings, 0 replies; 2+ messages in thread
  From: William Morgan @ 2008-11-10  4:55 UTC (permalink / raw)
  
  
  Reformatted excerpts from Steve Goldman's message of 2008-11-07:
  > We shouldn't downcase names before we look them up in the alias to
  > person hash since the keys of that hash are case sensitive.  This
  > brings up a more philosophical question of whether keys in that hash
  > SHOULD be case sensitive.  What does it mean to have two aliases
  > "Steve" and "steve"?
  
  Certainly, either everything should be case sensitive, or everything
  should be case insensitive. The problem here was that creating aliases
  was case sensitive, but looking them up wasn't.
  
  Personally I'm fine with case-sensitive aliases. Applied, thanks!
  -- 
  William <wmorgan-sup at masanjin.net>
  
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-10  4:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-07 20:04 [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased Steve Goldman
2008-11-10  4:55 ` William Morgan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox