From mboxrd@z Thu Jan 1 00:00:00 1970 From: sgoldman@tower-research.com (Steve Goldman) Date: Fri, 07 Nov 2008 15:04:33 -0500 Subject: [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased. Message-ID: <1226088207-sup-2545@sgoldmanlinux.tower-research.com> --- We shouldn't downcase names before we look them up in the alias to person hash since the keys of that hash are case sensitive. This brings up a more philosophical question of whether keys in that hash SHOULD be case sensitive. What does it mean to have two aliases "Steve" and "steve"? lib/sup/buffer.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb index ebc3587..0447f61 100644 --- a/lib/sup/buffer.rb +++ b/lib/sup/buffer.rb @@ -506,7 +506,7 @@ EOS answer = BufferManager.ask_many_emails_with_completions domain, question, completions, default if answer - answer.split_on_commas.map { |x| ContactManager.contact_for(x.downcase) || PersonManager.person_for(x) } + answer.split_on_commas.map { |x| ContactManager.contact_for(x) || PersonManager.person_for(x) } end end -- 1.5.5 -- Steve Goldman sgoldman at tower-research.com T: 212.219.6014 F: 212.219.6007 Tower Research Capital, LLC 377 Broadway, 11th Fl. New York, NY 10013