From: sgoldman@tower-research.com (Steve Goldman)
Subject: [sup-talk] [PATCH] don't downcase names before looking them up in the alias to person map, since keys in that map aren't downcased.
Date: Fri, 07 Nov 2008 15:04:33 -0500 [thread overview]
Message-ID: <1226088207-sup-2545@sgoldmanlinux.tower-research.com> (raw)
---
We shouldn't downcase names before we look them up in the alias to
person hash since the keys of that hash are case sensitive. This
brings up a more philosophical question of whether keys in that hash
SHOULD be case sensitive. What does it mean to have two aliases
"Steve" and "steve"?
lib/sup/buffer.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index ebc3587..0447f61 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -506,7 +506,7 @@ EOS
answer = BufferManager.ask_many_emails_with_completions domain, question, completions, default
if answer
- answer.split_on_commas.map { |x| ContactManager.contact_for(x.downcase) || PersonManager.person_for(x) }
+ answer.split_on_commas.map { |x| ContactManager.contact_for(x) || PersonManager.person_for(x) }
end
end
--
1.5.5
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
next reply other threads:[~2008-11-07 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 20:04 Steve Goldman [this message]
2008-11-10 4:55 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226088207-sup-2545@sgoldmanlinux.tower-research.com \
--to=sgoldman@tower-research.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox