From mboxrd@z Thu Jan 1 00:00:00 1970 From: sgoldman@tower-research.com (Steve Goldman) Date: Fri, 07 Nov 2008 13:46:07 -0500 Subject: [sup-talk] Can't figure out how to use aliases In-Reply-To: <1226002395-sup-9614@sgoldmanlinux.tower-research.com> References: <1225897590-sup-8793@sgoldmanlinux.tower-research.com> <1226000889-sup-5922@entry> <1226002395-sup-9614@sgoldmanlinux.tower-research.com> Message-ID: <1226083370-sup-4870@sgoldmanlinux.tower-research.com> diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb index ebc3587..0447f61 100644 --- a/lib/sup/buffer.rb +++ b/lib/sup/buffer.rb @@ -506,7 +506,7 @@ EOS answer = BufferManager.ask_many_emails_with_completions domain, question, completions, default if answer - answer.split_on_commas.map { |x| ContactManager.contact_for(x.downcase) || PersonManager.person_for(x) } + answer.split_on_commas.map { |x| ContactManager.contact_for(x) || PersonManager.person_for(x) } end end We shouldn't downcase names before we look them up in the alias to person hash since the keys of that hash are case sensitive. This brings up a more philosophical question of whether keys in that hash SHOULD be case sensitive. What does it mean to have two aliases "Steve" and "steve"? Excerpts from Steve Goldman's message of Thu Nov 06 15:15:15 -0500 2008: > Testing it out, it seems to be a casing issue. When the alias I > choose is all lowercase, it works. Looks like when sup throws me into > my editor to compose the email, it lower cases the entire alias. Then > when it comes back out, it can't match the lower cased alias if the > alias had upper case letters. > > Excerpts from William Morgan's message of Thu Nov 06 14:49:47 -0500 2008: > > Reformatted excerpts from Steve Goldman's message of 2008-11-05: > > > I can't get sup to replace an alias with its email address when I send > > > To: an alias. This is really confusing. > > > > This should happen automagically, if you enter the alias either when > > Sup prompts you, or if it's on a To/Cc/Bcc line when you exit the editor > > and return to Sup. > > > > Are you sure you're typing in the right alias? > -- > > Steve Goldman > sgoldman at tower-research.com > > T: 212.219.6014 > F: 212.219.6007 > > Tower Research Capital, LLC > 377 Broadway, 11th Fl. > New York, NY 10013 -- Steve Goldman sgoldman at tower-research.com T: 212.219.6014 F: 212.219.6007 Tower Research Capital, LLC 377 Broadway, 11th Fl. New York, NY 10013