From: sgoldman@tower-research.com (Steve Goldman)
Subject: [sup-talk] Can't figure out how to use aliases
Date: Fri, 07 Nov 2008 13:46:07 -0500 [thread overview]
Message-ID: <1226083370-sup-4870@sgoldmanlinux.tower-research.com> (raw)
In-Reply-To: <1226002395-sup-9614@sgoldmanlinux.tower-research.com>
diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb
index ebc3587..0447f61 100644
--- a/lib/sup/buffer.rb
+++ b/lib/sup/buffer.rb
@@ -506,7 +506,7 @@ EOS
answer = BufferManager.ask_many_emails_with_completions domain, question, completions, default
if answer
- answer.split_on_commas.map { |x| ContactManager.contact_for(x.downcase) || PersonManager.person_for(x) }
+ answer.split_on_commas.map { |x| ContactManager.contact_for(x) || PersonManager.person_for(x) }
end
end
We shouldn't downcase names before we look them up in the alias to
person hash since the keys of that hash are case sensitive. This
brings up a more philosophical question of whether keys in that hash
SHOULD be case sensitive. What does it mean to have two aliases
"Steve" and "steve"?
Excerpts from Steve Goldman's message of Thu Nov 06 15:15:15 -0500 2008:
> Testing it out, it seems to be a casing issue. When the alias I
> choose is all lowercase, it works. Looks like when sup throws me into
> my editor to compose the email, it lower cases the entire alias. Then
> when it comes back out, it can't match the lower cased alias if the
> alias had upper case letters.
>
> Excerpts from William Morgan's message of Thu Nov 06 14:49:47 -0500 2008:
> > Reformatted excerpts from Steve Goldman's message of 2008-11-05:
> > > I can't get sup to replace an alias with its email address when I send
> > > To: an alias. This is really confusing.
> >
> > This should happen automagically, if you enter the alias either when
> > Sup prompts you, or if it's on a To/Cc/Bcc line when you exit the editor
> > and return to Sup.
> >
> > Are you sure you're typing in the right alias?
> --
>
> Steve Goldman
> sgoldman at tower-research.com
>
> T: 212.219.6014
> F: 212.219.6007
>
> Tower Research Capital, LLC
> 377 Broadway, 11th Fl.
> New York, NY 10013
--
Steve Goldman
sgoldman at tower-research.com
T: 212.219.6014
F: 212.219.6007
Tower Research Capital, LLC
377 Broadway, 11th Fl.
New York, NY 10013
prev parent reply other threads:[~2008-11-07 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 15:08 Steve Goldman
2008-11-06 19:49 ` William Morgan
2008-11-06 20:15 ` Steve Goldman
2008-11-07 18:46 ` Steve Goldman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226083370-sup-4870@sgoldmanlinux.tower-research.com \
--to=sgoldman@tower-research.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox