From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Subject: [sup-talk] [PATCH] Wrap text attachments
Date: Tue, 04 Nov 2008 14:29:40 +0100 [thread overview]
Message-ID: <1225805250-sup-3958@ausone.local> (raw)
In-Reply-To: <1225757268-sup-9251@elly>
Excerpts from Israel Herraiz's message of Tue Nov 04 01:08:41 +0100 2008:
> Hi,
Hi,
> this patch wrap text attachaments, as well as messages. For me is
> quite annoying to have to scroll to see the text attachments. Perhaps
> it is useful for others too.
I have no opinion about this change.
However there is already a WRAP_LEN constant in this file, please provide
a patch that reuse the same constant.
Best regards,
> ---
> lib/sup/message-chunks.rb | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/sup/message-chunks.rb b/lib/sup/message-chunks.rb
> index cc895f3..99bd12b 100644
> --- a/lib/sup/message-chunks.rb
> +++ b/lib/sup/message-chunks.rb
> @@ -65,6 +65,8 @@ Return value:
> EOS
> #' stupid ruby-mode
>
> + WRAP_LEN = 80 # wrap text attachments at this width
> +
> ## raw_content is the post-MIME-decode content. this is used for
> ## saving the attachment to disk.
> attr_reader :content_type, :filename, :lines, :raw_content
> @@ -95,6 +97,7 @@ EOS
> @lines = nil
> if text
> @lines = text.gsub("\r\n", "\n").gsub(/\t/, " ").gsub(/\r/, "").split("\n")
> + @lines = lines.map {|l| l.chomp.wrap WRAP_LEN}.flatten
> @quotable = true
> end
> end
--
Nicolas Pouillard aka Ertai
next prev parent reply other threads:[~2008-11-04 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 0:08 Israel Herraiz
2008-11-04 13:29 ` Nicolas Pouillard [this message]
2008-11-04 14:07 ` Israel Herraiz
2008-11-07 16:55 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225805250-sup-3958@ausone.local \
--to=nicolas.pouillard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox