* [sup-talk] [Patch] From auto completion
@ 2008-05-02 17:50 Tyberius Prime
2008-05-25 3:27 ` William Morgan
0 siblings, 1 reply; 2+ messages in thread
From: Tyberius Prime @ 2008-05-02 17:50 UTC (permalink / raw)
Hi all,
attached you'll find two patches ment to be applied together (*)
The first one introduces From: auto completion in edit-message
mode (plus key shortcut "f"),
the second adds a From: question when composing messages
(config ask_for_from, again with auto completion) and improves
the auto completion to be "Name <address>" instead of just "address".
Motivation: I have to send mail from different accounts,
and am tired of typing in the full sender each time.
(*) Sorry, I can't quite get git to export them as one right now :(
Also, I'll bear any comments on my code - this is the first ruby
I've ever written.
So long,
Tyberius Prime
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Autocomplete-editing-for-from-in-edit-message-mode-and-a-key-shortcut-for-it.txt
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20080502/70280483/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-add-from-query-on-compose-configuration-option-autocomplete.txt
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20080502/70280483/attachment-0001.txt>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [sup-talk] [Patch] From auto completion
2008-05-02 17:50 [sup-talk] [Patch] From auto completion Tyberius Prime
@ 2008-05-25 3:27 ` William Morgan
0 siblings, 0 replies; 2+ messages in thread
From: William Morgan @ 2008-05-25 3:27 UTC (permalink / raw)
Hi Tyberius,
Thanks for the patch. You can merge multiple commits together with git
rebase -i, or you can commit --amend each time to merge current changes
into the previous commit.
I like the idea of this patch, but instead of
AccountManager#user_accounts_autocompletion, could you add a
BufferManager#ask_for_account, similar to #ask_for_contact works? Then
the whole flow will be basically the same as editing the other fields.
Also note that you don't need semicolons at the end of statements in
Ruby. :)
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-25 3:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-02 17:50 [sup-talk] [Patch] From auto completion Tyberius Prime
2008-05-25 3:27 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox