Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [Patch] From auto completion
Date: Sat, 24 May 2008 20:27:36 -0700	[thread overview]
Message-ID: <1211685809-sup-4570@south> (raw)
In-Reply-To: <1209750543-sup-2407@h984274.serverkompetenz.net>

Hi Tyberius,

Thanks for the patch. You can merge multiple commits together with git
rebase -i, or you can commit --amend each time to merge current changes
into the previous commit.

I like the idea of this patch, but instead of
AccountManager#user_accounts_autocompletion, could you add a
BufferManager#ask_for_account, similar to #ask_for_contact works? Then
the whole flow will be basically the same as editing the other fields.

Also note that you don't need semicolons at the end of statements in
Ruby. :)
-- 
William <wmorgan-sup at masanjin.net>


      reply	other threads:[~2008-05-25  3:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02 17:50 Tyberius Prime
2008-05-25  3:27 ` William Morgan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211685809-sup-4570@south \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox