Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: marcus-sup@bar-coded.net (Marcus Williams)
Subject: [sup-talk] [PATCH] Add list-id as a new property of messages
Date: Fri, 25 Apr 2008 22:15:38 +0100	[thread overview]
Message-ID: <1209157604-sup-2682@tomsk> (raw)
In-Reply-To: <1209156188-sup-868@elly>

On 25.4.2008, Israel Herraiz wrote:
> Yes, I know. The "problem" is that List-Id use to have two fields: one
> that is a name, and another one that is a address-like. I wanted to
> use that last field and no the name for the automatic label. That's
> why I have used PersonManager to process the List-Id header.

:) I'm not saying you shouldnt do it - just that personally I dont
think you should do it in the place you do it. If you make list-id the
raw header in your patch then you can do the person manager lookup in
your before-add-message labeling hook (assuming thats where you're
labeling stuff). That way someone that wants to do something different
with the list-id header can do because you've given them the raw
header contents. 

Having said all that, you can access the raw headers directly from the
message object in the hook anyway so maybe this is a non-issue. I'll
shut up :)

Marcus


      reply	other threads:[~2008-04-25 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 21:23 Israel Herraiz
2008-04-24  8:54 ` Marcus Williams
2008-04-25 20:46   ` Israel Herraiz
2008-04-25 21:15     ` Marcus Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209157604-sup-2682@tomsk \
    --to=marcus-sup@bar-coded.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox