From mboxrd@z Thu Jan  1 00:00:00 1970
From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Date: Wed, 23 Apr 2008 10:59:24 +0200
Subject: [sup-talk] [PATCH] Fix a bug about forwarding that trimmed out
	newlines.
In-Reply-To: <1208915002-sup-1755@south>
References: <1207325353-7638-1-git-send-email-nicolas.pouillard@gmail.com>
	<1208764937-sup-2539@ausone.inria.fr> <1208915002-sup-1755@south>
Message-ID: <1208941031-sup-1885@port-ext16.ensta.fr>

Excerpts from William Morgan's message of Wed Apr 23 03:44:26 +0200 2008:
> Reformatted excerpts from nicolas.pouillard's message of 2008-04-21:
> > What about this patch?
> 
> I merged a more minor version of the fix into next.

Great!

However this hunk is useless:

====================================================================================
--- a/lib/sup/modes/edit-message-mode.rb
+++ b/lib/sup/modes/edit-message-mode.rb
@@ -122,7 +122,7 @@ EOS
     @file = Tempfile.new "sup.#{self.class.name.gsub(/.*::/, '').camel_to_hyphy}"
     @file.puts format_headers(@header - NON_EDITABLE_HEADERS).first
     @file.puts
-    @file.puts @body
+    @file.puts @body.join("\n")
     @file.close
 
     editor = $config[:editor] || ENV['EDITOR'] || "/usr/bin/vi"
====================================================================================

Since  puts of an array have the same semantics, but cheaper. However it worth
a comment to make it crystal clear.

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080423/d3ac93fb/attachment.bin