From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Subject: [sup-talk] [PATCH] Use read instead of readlines.join.
Date: Mon, 21 Apr 2008 10:02:59 +0200 [thread overview]
Message-ID: <1208764973-sup-7179@ausone.inria.fr> (raw)
In-Reply-To: <1207324856-7408-1-git-send-email-nicolas.pouillard@gmail.com>
What about this patch?
Excerpts from Nicolas Pouillard's message of Fri Apr 04 18:00:56 +0200 2008:
> ---
> lib/sup/draft.rb | 2 +-
> lib/sup/hook.rb | 2 +-
> lib/sup/maildir.rb | 2 +-
> lib/sup/modes/file-browser-mode.rb | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/sup/draft.rb b/lib/sup/draft.rb
> index 81c0044..21de151 100644
> --- a/lib/sup/draft.rb
> +++ b/lib/sup/draft.rb
> @@ -106,7 +106,7 @@ class DraftLoader < Source
> end
>
> def raw_message offset
> - IO.readlines(fn_for_offset(offset)).join
> + IO.read(fn_for_offset(offset))
> end
>
> def start_offset; 0; end
> diff --git a/lib/sup/hook.rb b/lib/sup/hook.rb
> index 74ecfab..9494919 100644
> --- a/lib/sup/hook.rb
> +++ b/lib/sup/hook.rb
> @@ -120,7 +120,7 @@ private
> unless @hooks.member? name
> @hooks[name] =
> begin
> - returning IO.readlines(fn_for(name)).join do
> + returning IO.read(fn_for(name)) do
> log "read '#{name}' from #{fn_for(name)}"
> end
> rescue SystemCallError => e
> diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb
> index 584e657..620e8e2 100644
> --- a/lib/sup/maildir.rb
> +++ b/lib/sup/maildir.rb
> @@ -72,7 +72,7 @@ class Maildir < Source
>
> def raw_message id
> scan_mailbox
> - with_file_for(id) { |f| f.readlines.join }
> + with_file_for(id) { |f| f.read }
> end
>
> def scan_mailbox opts={}
> diff --git a/lib/sup/modes/file-browser-mode.rb b/lib/sup/modes/file-browser-mode.rb
> index b49f3f4..b92468d 100644
> --- a/lib/sup/modes/file-browser-mode.rb
> +++ b/lib/sup/modes/file-browser-mode.rb
> @@ -47,7 +47,7 @@ protected
> return unless f && f.file?
>
> begin
> - BufferManager.spawn f.to_s, TextMode.new(f.readlines.join)
> + BufferManager.spawn f.to_s, TextMode.new(f.read)
> rescue SystemCallError => e
> BufferManager.flash e.message
> end
--
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080421/86548146/attachment.bin
next prev parent reply other threads:[~2008-04-21 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 16:00 Nicolas Pouillard
2008-04-21 8:02 ` Nicolas Pouillard [this message]
2008-04-23 1:43 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208764973-sup-7179@ausone.inria.fr \
--to=nicolas.pouillard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox