From mboxrd@z Thu Jan  1 00:00:00 1970
From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Date: Mon, 21 Apr 2008 10:01:45 +0200
Subject: [sup-talk] [PATCH] Write sup-{exception-log,
	unable-to-decode}.txt in ~/.sup
In-Reply-To: <12072321792626-git-send-email-nicolas.pouillard@gmail.com>
References: <12072321792626-git-send-email-nicolas.pouillard@gmail.com>
Message-ID: <1208764889-sup-5055@ausone.inria.fr>

What about applying this patch?

Excerpts from Nicolas Pouillard's message of Thu Apr 03 16:16:19 +0200 2008:
> More precisely new destinations are:
>   - ~/.sup/exception-log.txt
>   - ~/.sup/unable-to-decode.txt
> This patch avoid some kind of pollution.
> ---
>  bin/sup            |    4 ++--
>  lib/sup/message.rb |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/bin/sup b/bin/sup
> index 0d34215..a7623de 100644
> --- a/bin/sup
> +++ b/bin/sup
> @@ -327,7 +327,7 @@ ensure
>  end
>  
>  unless $exceptions.empty?
> -  File.open("sup-exception-log.txt", "w") do |f|
> +  File.open(File.join(BASE_DIR, "exception-log.txt"), "w") do |f|
>      $exceptions.each do |e, name|
>        f.puts "--- #{e.class.name} from thread: #{name}"
>        f.puts e.message, e.backtrace
> @@ -337,7 +337,7 @@ unless $exceptions.empty?
>  ----------------------------------------------------------------
>  I'm very sorry. It seems that an error occurred in Sup. Please
>  accept my sincere apologies. If you don't mind, please send the
> -contents of sup-exception-log.txt and a brief report of the
> +contents of ~/.sup/exception-log.txt and a brief report of the
>  circumstances to sup-talk at rubyforge dot orgs so that I might
>  address this problem. Thank you!
>  
> diff --git a/lib/sup/message.rb b/lib/sup/message.rb
> index 6a2a9c4..249b6c6 100644
> --- a/lib/sup/message.rb
> +++ b/lib/sup/message.rb
> @@ -423,7 +423,7 @@ private
>        Iconv.iconv($encoding + "//IGNORE", charset, body + " ").join[0 .. -2]
>      rescue Errno::EINVAL, Iconv::InvalidEncoding, Iconv::IllegalSequence, MessageFormatError => e
>        Redwood::log "warning: error (#{e.class.name}) decoding message body from #{charset}: #{e.message}"
> -      File.open("sup-unable-to-decode.txt", "w") { |f| f.write body }
> +      File.open(File.join(BASE_DIR,"unable-to-decode.txt"), "w") { |f| f.write body }
>        body
>      end
>    end

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080421/e75f4850/attachment.bin