From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.pouillard@gmail.com (Nicolas Pouillard) Date: Sat, 05 Apr 2008 11:26:19 +0200 Subject: [sup-talk] [PATCH] Fix a bug about forwarding that trimmed out newlines. In-Reply-To: <1207331132-sup-5937@south> References: <1207325353-7638-1-git-send-email-nicolas.pouillard@gmail.com> <1207331132-sup-5937@south> Message-ID: <1207387471-sup-7303@ausone.local> Excerpts from William Morgan's message of Fri Apr 04 19:47:31 +0200 2008: > Reformatted excerpts from nicolas.pouillard's message of 2008-04-04: > > This seems to happen when one don't touch the forwarded email. Indeed > > most of the sup's code tend to assume that messages body are > > reprensented using an array of string *without* a trailing \n, except > > some parts of the code. > > I see. I think this patch is the right approach. > > > This patch enforce that. It could become even more strict by raising > > an error instead of logging in join_lines. > > Does that log message ever get triggered for you? I'd prefer to have an > exception thrown, but only if it will never happen. :) I will change it to an exception for some time, and if it's good, I will submit a patch. For now I think this patch is the safe way. -- Nicolas Pouillard aka Ertai -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 286 bytes Desc: not available Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080405/6d0c0693/attachment.bin