From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Subject: [sup-talk] [PATCH] Fix a bug about forwarding that trimmed out newlines.
Date: Sat, 05 Apr 2008 11:26:19 +0200 [thread overview]
Message-ID: <1207387471-sup-7303@ausone.local> (raw)
In-Reply-To: <1207331132-sup-5937@south>
Excerpts from William Morgan's message of Fri Apr 04 19:47:31 +0200 2008:
> Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:
> > This seems to happen when one don't touch the forwarded email. Indeed
> > most of the sup's code tend to assume that messages body are
> > reprensented using an array of string *without* a trailing \n, except
> > some parts of the code.
>
> I see. I think this patch is the right approach.
>
> > This patch enforce that. It could become even more strict by raising
> > an error instead of logging in join_lines.
>
> Does that log message ever get triggered for you? I'd prefer to have an
> exception thrown, but only if it will never happen. :)
I will change it to an exception for some time, and if it's good, I will
submit a patch. For now I think this patch is the safe way.
--
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 286 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080405/6d0c0693/attachment.bin
next prev parent reply other threads:[~2008-04-05 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 16:09 Nicolas Pouillard
2008-04-04 17:47 ` William Morgan
2008-04-05 9:26 ` Nicolas Pouillard [this message]
2008-04-21 8:02 ` Nicolas Pouillard
2008-04-23 1:44 ` William Morgan
2008-04-23 8:59 ` Nicolas Pouillard
2008-04-04 16:16 kendall at clarkparsia.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207387471-sup-7303@ausone.local \
--to=nicolas.pouillard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox