From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] Fix a bug about forwarding that trimmed out newlines.
Date: Fri, 04 Apr 2008 10:47:31 -0700 [thread overview]
Message-ID: <1207331132-sup-5937@south> (raw)
In-Reply-To: <1207325353-7638-1-git-send-email-nicolas.pouillard@gmail.com>
Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:
> This seems to happen when one don't touch the forwarded email. Indeed
> most of the sup's code tend to assume that messages body are
> reprensented using an array of string *without* a trailing \n, except
> some parts of the code.
I see. I think this patch is the right approach.
> This patch enforce that. It could become even more strict by raising
> an error instead of logging in join_lines.
Does that log message ever get triggered for you? I'd prefer to have an
exception thrown, but only if it will never happen. :)
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2008-04-04 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 16:09 Nicolas Pouillard
2008-04-04 17:47 ` William Morgan [this message]
2008-04-05 9:26 ` Nicolas Pouillard
2008-04-21 8:02 ` Nicolas Pouillard
2008-04-23 1:44 ` William Morgan
2008-04-23 8:59 ` Nicolas Pouillard
2008-04-04 16:16 kendall at clarkparsia.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207331132-sup-5937@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox