* [sup-talk] About newlines
@ 2008-04-04 12:14 Nicolas Pouillard
2008-04-04 16:08 ` William Morgan
2008-04-04 16:16 ` Marc Hartstein
0 siblings, 2 replies; 6+ messages in thread
From: Nicolas Pouillard @ 2008-04-04 12:14 UTC (permalink / raw)
I'm hitting a bug concerning forwarding, all newlines get trimmed off. I'm
trying to fix the bug, but I don't understand if arrays of lines are supposed
to be ended by newlines or not.
--
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080404/acbb1193/attachment.bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [sup-talk] About newlines
2008-04-04 12:14 [sup-talk] About newlines Nicolas Pouillard
@ 2008-04-04 16:08 ` William Morgan
2008-04-04 16:10 ` Nicolas Pouillard
2008-04-04 16:16 ` Marc Hartstein
1 sibling, 1 reply; 6+ messages in thread
From: William Morgan @ 2008-04-04 16:08 UTC (permalink / raw)
Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:
> I'm hitting a bug concerning forwarding, all newlines get trimmed
> off. I'm trying to fix the bug, but I don't understand if arrays of
> lines are supposed to be ended by newlines or not.
I don't see this behavior, either in the forward mode buffer or in the
resulting message.
Newlines shouldn't exist in arrays of lines.
ForwardMode#forward_body_lines is the relevant method. Let me know what
you discover.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [sup-talk] About newlines
2008-04-04 16:08 ` William Morgan
@ 2008-04-04 16:10 ` Nicolas Pouillard
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Pouillard @ 2008-04-04 16:10 UTC (permalink / raw)
Excerpts from William Morgan's message of Fri Apr 04 18:08:02 +0200 2008:> Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:> > I'm hitting a bug concerning forwarding, all newlines get trimmed> > off. I'm trying to fix the bug, but I don't understand if arrays of> > lines are supposed to be ended by newlines or not.> > I don't see this behavior, either in the forward mode buffer or in the> resulting message.> > Newlines shouldn't exist in arrays of lines.> ForwardMode#forward_body_lines is the relevant method. Let me know what> you discover.I hope that my bunch of patches will makes this clear.-- Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080404/ca47ba3b/attachment.bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [sup-talk] About newlines
2008-04-04 12:14 [sup-talk] About newlines Nicolas Pouillard
2008-04-04 16:08 ` William Morgan
@ 2008-04-04 16:16 ` Marc Hartstein
1 sibling, 0 replies; 6+ messages in thread
From: Marc Hartstein @ 2008-04-04 16:16 UTC (permalink / raw)
Excerpts from Nicolas Pouillard's message of Fri Apr 04 08:14:06 -0400 2008:
> I'm hitting a bug concerning forwarding, all newlines get trimmed off. I'm
> trying to fix the bug, but I don't understand if arrays of lines are supposed
> to be ended by newlines or not.
After a bit of chat in #sup on freenode, I have a workaround and some
comments.
Workaround (tested): make sure you instruct your editor to save the
temporary file even when you are making no changes. This will force sup
to capture the contents of the file, which will include the newlines.
New bug: the same bug exists when replying if you don't edit your
message before sending (why would you ever do that?)
The problem seems to be that when the body of forward/reply messages is
built, it is built without a newline terminator at the end of every
line. This is infrequently noticed because those newlines get added to
the temporary file for editing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20080404/0ecde927/attachment.bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [sup-talk] About newlines
@ 2008-04-04 13:13 kendall at clarkparsia.com
0 siblings, 0 replies; 6+ messages in thread
From: kendall at clarkparsia.com @ 2008-04-04 13:13 UTC (permalink / raw)
On Friday, April 4, 2008 8:14am, Nicolas Pouillard <nicolas.pouillard at gmail.com> said:
> _______________________________________________
> sup-talk mailing list
> sup-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/sup-talk
> I'm hitting a bug concerning forwarding, all newlines get trimmed off. I'm
> trying to fix the bug, but I don't understand if arrays of lines are supposed
> to be ended by newlines or not.
This is also a problem for me, though I haven't tried to fix it. :>
Cheers,
Kendall
^ permalink raw reply [flat|nested] 6+ messages in thread
* [sup-talk] About newlines
@ 2008-04-04 16:17 kendall at clarkparsia.com
0 siblings, 0 replies; 6+ messages in thread
From: kendall at clarkparsia.com @ 2008-04-04 16:17 UTC (permalink / raw)
This is precisely what my correspondents see when I forward messages w/out editing them from sup -- and they yell at me, which isn't fun. :>
Cheers,
Kendall
PS--Sorry for the top post, but it seemed reasonable here (and I'm not using sup today!).
On Friday, April 4, 2008 12:10pm, Nicolas Pouillard <nicolas.pouillard at gmail.com> said:
> _______________________________________________
> sup-talk mailing list
> sup-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/sup-talk
> Excerpts from William Morgan's message of Fri Apr 04 18:08:02 +0200 2008:>
> Reformatted excerpts from nicolas.pouillard's message of 2008-04-04:> > I'm
> hitting a bug concerning forwarding, all newlines get trimmed> > off. I'm
> trying to fix the bug, but I don't understand if arrays of> > lines are supposed
> to be ended by newlines or not.> > I don't see this behavior, either in the
> forward mode buffer or in the> resulting message.> > Newlines shouldn't exist in
> arrays of lines.> ForwardMode#forward_body_lines is the relevant method. Let me
> know what> you discover.I hope that my bunch of patches will makes this clear.--
> Nicolas Pouillard aka Ertai
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-04-04 16:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-04 12:14 [sup-talk] About newlines Nicolas Pouillard
2008-04-04 16:08 ` William Morgan
2008-04-04 16:10 ` Nicolas Pouillard
2008-04-04 16:16 ` Marc Hartstein
2008-04-04 13:13 kendall at clarkparsia.com
2008-04-04 16:17 kendall at clarkparsia.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox