Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Subject: [sup-talk] [PATCH] Write sup-{exception-log, unable-to-decode}.txt in ~/.sup
Date: Thu,  3 Apr 2008 16:16:19 +0200	[thread overview]
Message-ID: <12072321792626-git-send-email-nicolas.pouillard@gmail.com> (raw)

More precisely new destinations are:
  - ~/.sup/exception-log.txt
  - ~/.sup/unable-to-decode.txt
This patch avoid some kind of pollution.
---
 bin/sup            |    4 ++--
 lib/sup/message.rb |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bin/sup b/bin/sup
index 0d34215..a7623de 100644
--- a/bin/sup
+++ b/bin/sup
@@ -327,7 +327,7 @@ ensure
 end
 
 unless $exceptions.empty?
-  File.open("sup-exception-log.txt", "w") do |f|
+  File.open(File.join(BASE_DIR, "exception-log.txt"), "w") do |f|
     $exceptions.each do |e, name|
       f.puts "--- #{e.class.name} from thread: #{name}"
       f.puts e.message, e.backtrace
@@ -337,7 +337,7 @@ unless $exceptions.empty?
 ----------------------------------------------------------------
 I'm very sorry. It seems that an error occurred in Sup. Please
 accept my sincere apologies. If you don't mind, please send the
-contents of sup-exception-log.txt and a brief report of the
+contents of ~/.sup/exception-log.txt and a brief report of the
 circumstances to sup-talk at rubyforge dot orgs so that I might
 address this problem. Thank you!
 
diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 6a2a9c4..249b6c6 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -423,7 +423,7 @@ private
       Iconv.iconv($encoding + "//IGNORE", charset, body + " ").join[0 .. -2]
     rescue Errno::EINVAL, Iconv::InvalidEncoding, Iconv::IllegalSequence, MessageFormatError => e
       Redwood::log "warning: error (#{e.class.name}) decoding message body from #{charset}: #{e.message}"
-      File.open("sup-unable-to-decode.txt", "w") { |f| f.write body }
+      File.open(File.join(BASE_DIR,"unable-to-decode.txt"), "w") { |f| f.write body }
       body
     end
   end
-- 
1.5.3.1.109.gacd69



             reply	other threads:[~2008-04-03 14:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03 14:16 Nicolas Pouillard [this message]
2008-04-06 11:06 ` Giorgio Lando
2008-04-21  8:01 ` Nicolas Pouillard
2008-04-23  1:43   ` William Morgan
2008-04-23  8:59     ` Nicolas Pouillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12072321792626-git-send-email-nicolas.pouillard@gmail.com \
    --to=nicolas.pouillard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox