From mboxrd@z Thu Jan  1 00:00:00 1970
From: marcus-sup@bar-coded.net (Marcus Williams)
Date: Thu, 28 Feb 2008 21:15:42 +0000
Subject: [sup-talk] [PATCH] First draft of attachment processing for
	more gmail style searches
In-Reply-To: <1204220051-sup-129@south>
References: <1203972458-sup-5906@tomsk> <1204220051-sup-129@south>
Message-ID: <1204232994-sup-628@tomsk>

On 28.2.2008, William Morgan wrote:
> Just reading the patch without having applied it yet, this looks pretty
> good. To answer the question in the comments, attachments with generated
> names are things that are meant to be displayed inline, not
> "download-worthy attachments", so I don't think they should be included
> in the list of attachments. 

Guessed as much (had to sup-sync -all about 10 times on a large imap
account to figure this out though! - although this has made me move to
offlineimap and maildirs which are _much_ faster so I gained something
in the end :)

The only thing I'm a little wary of is the join() I do of the
attachment filenames for the index (like labels). This means that
ferret doesnt actually know the difference between two files called
file1 and file2 and a single file called "file1 file2". Not sure it
matters that much for this usage though.

Also I dont repopulate the attachments attribute on the message object
and I couldnt figure out quite how you do it for labels (through the
initialise?). Might be nice to be able to query the attachments field
as a list on a message object much like labels. This then brought me
back to the problem of how to deal with spaces in filenames. It might
be that I should use some other character for the join thats unlikely
to be in a filename. Not sure what though.

Marcus