From: marcus-sup@bar-coded.net (Marcus Williams)
Subject: [sup-talk] [PATCH] First draft of attachment processing for more gmail style searches
Date: Thu, 28 Feb 2008 21:15:42 +0000 [thread overview]
Message-ID: <1204232994-sup-628@tomsk> (raw)
In-Reply-To: <1204220051-sup-129@south>
On 28.2.2008, William Morgan wrote:
> Just reading the patch without having applied it yet, this looks pretty
> good. To answer the question in the comments, attachments with generated
> names are things that are meant to be displayed inline, not
> "download-worthy attachments", so I don't think they should be included
> in the list of attachments.
Guessed as much (had to sup-sync -all about 10 times on a large imap
account to figure this out though! - although this has made me move to
offlineimap and maildirs which are _much_ faster so I gained something
in the end :)
The only thing I'm a little wary of is the join() I do of the
attachment filenames for the index (like labels). This means that
ferret doesnt actually know the difference between two files called
file1 and file2 and a single file called "file1 file2". Not sure it
matters that much for this usage though.
Also I dont repopulate the attachments attribute on the message object
and I couldnt figure out quite how you do it for labels (through the
initialise?). Might be nice to be able to query the attachments field
as a list on a message object much like labels. This then brought me
back to the problem of how to deal with spaces in filenames. It might
be that I should use some other character for the join thats unlikely
to be in a filename. Not sure what though.
Marcus
next prev parent reply other threads:[~2008-02-28 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 20:50 Marcus Williams
2008-02-28 17:40 ` William Morgan
2008-02-28 21:15 ` Marcus Williams [this message]
2008-03-02 18:08 ` William Morgan
2008-03-05 10:01 ` Marcus Williams
2008-03-08 22:02 ` William Morgan
2008-03-23 21:13 ` Marcus Williams
2008-04-02 20:51 ` William Morgan
2008-04-02 21:16 ` vasudeva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204232994-sup-628@tomsk \
--to=marcus-sup@bar-coded.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox