From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Thu, 28 Feb 2008 09:40:35 -0800 Subject: [sup-talk] [PATCH] First draft of attachment processing for more gmail style searches In-Reply-To: <1203972458-sup-5906@tomsk> References: <1203972458-sup-5906@tomsk> Message-ID: <1204220051-sup-129@south> Reformatted excerpts from Marcus Williams's message of 2008-02-25: > This patch adds the search terms "filename" and "filetype". This > changes the index so requires a sup-sync --all to work properly, but > should work on all new messages without it. Just reading the patch without having applied it yet, this looks pretty good. To answer the question in the comments, attachments with generated names are things that are meant to be displayed inline, not "download-worthy attachments", so I don't think they should be included in the list of attachments. (Sup only generates a name for them to allow external viewing programs to view them.) So I think the current implementation is correct on that point. -- William