From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] First draft of attachment processing for more gmail style searches
Date: Thu, 28 Feb 2008 09:40:35 -0800 [thread overview]
Message-ID: <1204220051-sup-129@south> (raw)
In-Reply-To: <1203972458-sup-5906@tomsk>
Reformatted excerpts from Marcus Williams's message of 2008-02-25:
> This patch adds the search terms "filename" and "filetype". This
> changes the index so requires a sup-sync --all to work properly, but
> should work on all new messages without it.
Just reading the patch without having applied it yet, this looks pretty
good. To answer the question in the comments, attachments with generated
names are things that are meant to be displayed inline, not
"download-worthy attachments", so I don't think they should be included
in the list of attachments. (Sup only generates a name for them to allow
external viewing programs to view them.) So I think the current
implementation is correct on that point.
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2008-02-28 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 20:50 Marcus Williams
2008-02-28 17:40 ` William Morgan [this message]
2008-02-28 21:15 ` Marcus Williams
2008-03-02 18:08 ` William Morgan
2008-03-05 10:01 ` Marcus Williams
2008-03-08 22:02 ` William Morgan
2008-03-23 21:13 ` Marcus Williams
2008-04-02 20:51 ` William Morgan
2008-04-02 21:16 ` vasudeva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204220051-sup-129@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox