From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] mime-view
Date: Tue, 19 Feb 2008 09:32:57 -0800 [thread overview]
Message-ID: <1203442283-sup-4449@south> (raw)
In-Reply-To: <1203393696-sup-1607@buckwheat>
Reformatted excerpts from Daniel Wagner's message of 2008-02-18:
> Recently, activating attachments has stopped working.
You know, in reexamining this code, I think there is a silly bug here,
and I think it also caused the weirdness that John Bent was experiencing
a few weeks ago.
Can you try the latest (master/next) from git, or apply the following
patch:
diff --git a/lib/sup/message-chunks.rb b/lib/sup/message-chunks.rb
index 0606395..ba8b846 100644
--- a/lib/sup/message-chunks.rb
+++ b/lib/sup/message-chunks.rb
@@ -126,7 +126,7 @@ EOS
path = write_to_disk
ret = HookManager.run "mime-view", :content_type => @content_type,
:filename => path
- view_default! path unless ret
+ ret || view_default!(path)
end
def write_to_disk
> system "xmessage -default okay In the hook."
> system "see #{content_type}:#{filename}"
> return true
This looks fine, though I would change the last line to just
$?.success?
which will evaluate to true iff the see command was successful. With
the above change, everything should Just Work (tm).
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2008-02-19 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 4:01 Daniel Wagner
2008-02-19 17:32 ` William Morgan [this message]
2008-02-19 17:54 ` John Bent
2008-02-19 17:56 ` William Morgan
2008-02-19 18:23 ` William Morgan
2008-02-20 6:59 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203442283-sup-4449@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox