From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Sat, 16 Feb 2008 12:04:32 -0800 Subject: [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message Message-ID: <1203192249-sup-6640@south> [forgot to send to list] Reformatted excerpts from brabuhr's message of 2008-02-08: > I was also thinking that it would be better to display the discovered > URIs in a list instead of the prompting, but I wasn't sure how to > implement that. Another problem I see is that the extractor is > too-greedy and will pull in the punctuation following the URL; so, > perhaps the list should allow line editing before calling the view-url > hook? If you want to display them as a list, I would add a mode called UrlListMode or something like that which was a subclass of LineCursorMode. You can look to BufferListMode as an example, though it will be even simpler than that because the content won't ever change. Spawn an instance of that mode when the user presses 'L', and have enter in UrlListMode trigger the URL viewing hook, possibly first running it through BufferManager#ask for editing. We can also trim trailing punctuation from whatever URI.extract pulls out, since that sounds like the common case. -- William