From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message
Date: Sat, 16 Feb 2008 12:04:32 -0800 [thread overview]
Message-ID: <1203192249-sup-6640@south> (raw)
[forgot to send to list]
Reformatted excerpts from brabuhr's message of 2008-02-08:
> I was also thinking that it would be better to display the discovered
> URIs in a list instead of the prompting, but I wasn't sure how to
> implement that. Another problem I see is that the extractor is
> too-greedy and will pull in the punctuation following the URL; so,
> perhaps the list should allow line editing before calling the view-url
> hook?
If you want to display them as a list, I would add a mode called
UrlListMode or something like that which was a subclass of
LineCursorMode. You can look to BufferListMode as an example, though it
will be even simpler than that because the content won't ever change.
Spawn an instance of that mode when the user presses 'L', and have
enter in UrlListMode trigger the URL viewing hook, possibly first
running it through BufferManager#ask for editing. We can also trim
trailing punctuation from whatever URI.extract pulls out, since that
sounds like the common case.
--
William <wmorgan-sup at masanjin.net>
next prev reply other threads:[~2008-02-16 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 3:23 brabuhr
2008-02-03 2:56 ` William Morgan
2008-02-09 2:01 ` brabuhr at gmail.com
2008-02-16 20:04 ` William Morgan [this message]
2008-02-16 20:06 ` [sup-talk] [PATCH] add URL extraction, listing, and viewing capabilities to ThreadViewMode William Morgan
2008-02-18 23:24 ` [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message Nicolas Pouillard
2008-02-19 3:12 ` Daniel Wagner
2008-02-19 10:17 ` Nicolas Pouillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203192249-sup-6640@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox