* [sup-talk] [PATCH] Show drafts in red, in thread-index-mode.
@ 2008-01-18 9:59 Nicolas Pouillard
2008-01-18 10:03 ` Nicolas Pouillard
2008-01-23 18:22 ` William Morgan
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Pouillard @ 2008-01-18 9:59 UTC (permalink / raw)
This patch would help to think about finishing drafts.
---
bin/sup | 2 ++
lib/sup/modes/thread-index-mode.rb | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/bin/sup b/bin/sup
index 7314227..a49e2c4 100644
--- a/bin/sup
+++ b/bin/sup
@@ -137,6 +137,8 @@ begin
Ncurses::A_BOLD
c.add :index_starred_color, Ncurses::COLOR_YELLOW, Ncurses::COLOR_BLACK,
Ncurses::A_BOLD
+ c.add :index_draft_color, Ncurses::COLOR_RED, Ncurses::COLOR_BLACK,
+ Ncurses::A_BOLD
c.add :labellist_old_color, Ncurses::COLOR_WHITE, Ncurses::COLOR_BLACK
c.add :labellist_new_color, Ncurses::COLOR_WHITE, Ncurses::COLOR_BLACK,
Ncurses::A_BOLD
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 0d90be4..fac7500 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -599,7 +599,6 @@ protected
date = t.date.to_nice_s
- new = t.has_label?(:unread)
starred = t.has_label?(:starred)
## format the from column
@@ -636,7 +635,9 @@ protected
p = dp || t.participants.any? { |p| AccountManager.is_account? p }
subj_color =
- if new
+ if t.has_label?(:draft)
+ :index_draft_color
+ elsif t.has_label?(:unread)
:index_new_color
elsif starred
:index_starred_color
--
1.5.3.1.109.gacd69
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] [PATCH] Show drafts in red, in thread-index-mode.
2008-01-18 9:59 [sup-talk] [PATCH] Show drafts in red, in thread-index-mode Nicolas Pouillard
@ 2008-01-18 10:03 ` Nicolas Pouillard
2008-01-23 18:22 ` William Morgan
1 sibling, 0 replies; 5+ messages in thread
From: Nicolas Pouillard @ 2008-01-18 10:03 UTC (permalink / raw)
Excerpts from Nicolas Pouillard's message of Fri Jan 18 10:59:59 +0100 2008:
> This patch would help to think about finishing drafts.
Colors and UI are rather user dependent, so it's just in case...
--
Nicolas Pouillard aka Ertai
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] [PATCH] Show drafts in red, in thread-index-mode.
2008-01-18 9:59 [sup-talk] [PATCH] Show drafts in red, in thread-index-mode Nicolas Pouillard
2008-01-18 10:03 ` Nicolas Pouillard
@ 2008-01-23 18:22 ` William Morgan
2008-02-09 12:05 ` Nicolas Pouillard
1 sibling, 1 reply; 5+ messages in thread
From: William Morgan @ 2008-01-23 18:22 UTC (permalink / raw)
Reformatted excerpts from nicolas.pouillard's message of 2008-01-18:
> This patch would help to think about finishing drafts.
I like it. There's trailing whitespace on the c.add line. After that I'm
happy to apply it.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] [PATCH] Show drafts in red, in thread-index-mode.
2008-01-23 18:22 ` William Morgan
@ 2008-02-09 12:05 ` Nicolas Pouillard
2008-02-16 19:20 ` William Morgan
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Pouillard @ 2008-02-09 12:05 UTC (permalink / raw)
This patch would help to think about finishing drafts.
---
bin/sup | 2 ++
lib/sup/modes/inbox-mode.rb | 2 +-
lib/sup/modes/thread-index-mode.rb | 5 +++--
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/bin/sup b/bin/sup
index 84fd77c..f536da6 100644
--- a/bin/sup
+++ b/bin/sup
@@ -138,6 +138,8 @@ begin
Ncurses::A_BOLD
c.add :index_starred_color, Ncurses::COLOR_YELLOW, Ncurses::COLOR_BLACK,
Ncurses::A_BOLD
+ c.add :index_draft_color, Ncurses::COLOR_RED, Ncurses::COLOR_BLACK,
+ Ncurses::A_BOLD
c.add :labellist_old_color, Ncurses::COLOR_WHITE, Ncurses::COLOR_BLACK
c.add :labellist_new_color, Ncurses::COLOR_WHITE, Ncurses::COLOR_BLACK,
Ncurses::A_BOLD
diff --git a/lib/sup/modes/inbox-mode.rb b/lib/sup/modes/inbox-mode.rb
index a2de13f..f156b69 100644
--- a/lib/sup/modes/inbox-mode.rb
+++ b/lib/sup/modes/inbox-mode.rb
@@ -9,7 +9,7 @@ class InboxMode < ThreadIndexMode
end
def initialize
- super [:inbox, :sent], { :label => :inbox, :skip_killed => true }
+ super [:inbox, :sent, :draft], { :label => :inbox, :skip_killed => true }
raise "can't have more than one!" if defined? @@instance
@@instance = self
end
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index e24d7e0..7a0b815 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -655,7 +655,6 @@ protected
date = t.date.to_nice_s
- new = t.has_label?(:unread)
starred = t.has_label?(:starred)
## format the from column
@@ -692,7 +691,9 @@ protected
p = dp || t.participants.any? { |p| AccountManager.is_account? p }
subj_color =
- if new
+ if t.has_label?(:draft)
+ :index_draft_color
+ elsif t.has_label?(:unread)
:index_new_color
elsif starred
:index_starred_color
--
1.5.3.1.109.gacd69
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-talk] [PATCH] Show drafts in red, in thread-index-mode.
2008-02-09 12:05 ` Nicolas Pouillard
@ 2008-02-16 19:20 ` William Morgan
0 siblings, 0 replies; 5+ messages in thread
From: William Morgan @ 2008-02-16 19:20 UTC (permalink / raw)
Reformatted excerpts from nicolas.pouillard's message of 2008-02-09:
> This patch would help to think about finishing drafts.
Merged into next. How do people like it? Thanks, Nicolas.
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-16 19:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-18 9:59 [sup-talk] [PATCH] Show drafts in red, in thread-index-mode Nicolas Pouillard
2008-01-18 10:03 ` Nicolas Pouillard
2008-01-23 18:22 ` William Morgan
2008-02-09 12:05 ` Nicolas Pouillard
2008-02-16 19:20 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox