From mboxrd@z Thu Jan 1 00:00:00 1970 From: chrisw@rice.edu (Christopher Warrington) Date: Tue, 05 Feb 2008 13:29:19 -0600 Subject: [sup-talk] [PATCH] shell commands are now run in a child process In-Reply-To: <1202232814-sup-1005@south> References: <1202026272-3432-2-git-send-email-chrisw@rice.edu> <1202232814-sup-1005@south> Message-ID: <1202239755-sup-3523@chris-tablet> Excerpts from William Morgan's message of Tue Feb 05 11:34:12 -0600 2008: >> When shelling out, the external command is now run in a child >> process. Before the external command is run, all (I hope) of sup's >> open files are closed first. > This seems crazy. Do mbox sources even continue to function properly > once this has happened? It seems like they'd crash with their file > handles closed from under them. No, it's not elegant at all. mbox sources do still work, though. I only close the files in the child process. They remain open in sup's main process. Setting the file descriptors to FD_CLOEXEC would be a cleaner solution, but I don't think that this works on Cygwin (or is accessible via Ruby). > If the issue is that Windows has bad behavior when Sup polls while > you're editing a message, another option might be to turn off polling > when Sup is shelled out. That's a thought. If I get some time, I may be able to dig into this. -- Christopher Warrington