From: chrisw@rice.edu (Christopher Warrington)
Subject: [sup-talk] [PATCH] shell commands are now run in a child process
Date: Tue, 05 Feb 2008 13:29:19 -0600 [thread overview]
Message-ID: <1202239755-sup-3523@chris-tablet> (raw)
In-Reply-To: <1202232814-sup-1005@south>
Excerpts from William Morgan's message of Tue Feb 05 11:34:12 -0600 2008:
>> When shelling out, the external command is now run in a child
>> process. Before the external command is run, all (I hope) of sup's
>> open files are closed first.
> This seems crazy. Do mbox sources even continue to function properly
> once this has happened? It seems like they'd crash with their file
> handles closed from under them.
No, it's not elegant at all. mbox sources do still work, though. I only
close the files in the child process. They remain open in sup's main
process.
Setting the file descriptors to FD_CLOEXEC would be a cleaner solution,
but I don't think that this works on Cygwin (or is accessible via Ruby).
> If the issue is that Windows has bad behavior when Sup polls while
> you're editing a message, another option might be to turn off polling
> when Sup is shelled out.
That's a thought. If I get some time, I may be able to dig into this.
--
Christopher Warrington <chrisw at rice.edu>
next prev parent reply other threads:[~2008-02-05 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 8:11 Christopher Warrington
2008-02-05 17:34 ` William Morgan
2008-02-05 19:29 ` Christopher Warrington [this message]
2008-02-05 20:12 ` William Morgan
2008-02-08 9:40 ` Christopher Warrington
2008-02-19 17:48 ` William Morgan
2008-02-25 17:48 William Morgan
2008-03-01 4:42 ` Christopher Warrington
2008-03-01 20:37 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202239755-sup-3523@chris-tablet \
--to=chrisw@rice.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox